Adding special keyword for themes with `holiday` tag

[rabmalin]

In Theme Review, we are now prioritizing the theme with holiday tag. If we can add some keyword (holiday or relevant) for theme tickets with holiday theme tag, we can then create separate Report here ​https://themes.trac.wordpress.org/report and it will be easier to monitor such themes.

Background - ​https://make.wordpress.org/themes/2017/11/19/get-your-holiday-themes-ready/

[grapplerulrich]

Would it make sense to add all of the tags in the ticket as keywords?

[dd32]

Replying to grapplerulrich:

Would it make sense to add all of the tags in the ticket as keywords?

Unless they're needed for querying, I wouldn't add them as keywords (Trac stores the keywords as a single long string). When querying by keyword you're really doing a wildcard query such as AND keywords LIKE '%holiday%'.

[rabmalin]

Replying to dd32:

Replying to grapplerulrich:

Would it make sense to add all of the tags in the ticket as keywords?

Unless they're needed for querying, I wouldn't add them as keywords (Trac stores the keywords as a single long string). When querying by keyword you're really doing a wildcard query such as AND keywords LIKE '%holiday%'.

Did not know about the trac system, but for me too, it is not worth to add all tags as keywords. There are several theme tags which we probably never need for query.

[dd32]

In 6153:

Theme Diretory: Add the 'holiday' keyword to Theme Trac tickets for filtering.

Props rabmalin.
Fixes #3276.

[dd32]

That should be enough to make ​https://themes.trac.wordpress.org/report/6 work I think (Let me know if that report needs altering and you don't have access)

However, note that because like I said, it's a wildcard search, some non-holiday themes will show up there ​when the theme name contains holiday

[rabmalin]

Replying to dd32:

That should be enough to make ​https://themes.trac.wordpress.org/report/6 work I think (Let me know if that report needs altering and you don't have access)

However, note that because like I said, it's a wildcard search, some non-holiday themes will show up there ​when the theme name contains holiday

Thanks for the commit. I understand your point. We now have at least separate report to monitor the tickets. If non-holiday themes comes in the report, we will handle manually.