WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#3276 closed enhancement (fixed)

Adding special keyword for themes with `holiday` tag

Reported by: rabmalin Owned by: dd32
Milestone: Priority: normal
Component: Theme Review Keywords: has-patch
Cc:

Description

In Theme Review, we are now prioritizing the theme with holiday tag. If we can add some keyword (holiday or relevant) for theme tickets with holiday theme tag, we can then create separate Report here https://themes.trac.wordpress.org/report and it will be easier to monitor such themes.

Background - https://make.wordpress.org/themes/2017/11/19/get-your-holiday-themes-ready/

Attachments (1)

3276.diff (767 bytes) - added by rabmalin 6 months ago.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in Slack in #themereview by rabmalin. View the logs.


6 months ago

@rabmalin
6 months ago

#2 @rabmalin
6 months ago

  • Keywords has-patch added; needs-patch removed

#3 follow-up: @grapplerulrich
6 months ago

Would it make sense to add all of the tags in the ticket as keywords?

#4 in reply to: ↑ 3 ; follow-up: @dd32
6 months ago

Replying to grapplerulrich:

Would it make sense to add all of the tags in the ticket as keywords?

Unless they're needed for querying, I wouldn't add them as keywords (Trac stores the keywords as a single long string). When querying by keyword you're really doing a wildcard query such as AND keywords LIKE '%holiday%'.

#5 in reply to: ↑ 4 @rabmalin
6 months ago

Replying to dd32:

Replying to grapplerulrich:

Would it make sense to add all of the tags in the ticket as keywords?

Unless they're needed for querying, I wouldn't add them as keywords (Trac stores the keywords as a single long string). When querying by keyword you're really doing a wildcard query such as AND keywords LIKE '%holiday%'.

Did not know about the trac system, but for me too, it is not worth to add all tags as keywords. There are several theme tags which we probably never need for query.

#6 @dd32
6 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 6153:

Theme Diretory: Add the 'holiday' keyword to Theme Trac tickets for filtering.

Props rabmalin.
Fixes #3276.

#7 follow-up: @dd32
6 months ago

That should be enough to make https://themes.trac.wordpress.org/report/6 work I think (Let me know if that report needs altering and you don't have access)

However, note that because like I said, it's a wildcard search, some non-holiday themes will show up there when the theme name contains holiday

#8 in reply to: ↑ 7 @rabmalin
6 months ago

Replying to dd32:

That should be enough to make https://themes.trac.wordpress.org/report/6 work I think (Let me know if that report needs altering and you don't have access)

However, note that because like I said, it's a wildcard search, some non-holiday themes will show up there when the theme name contains holiday

Thanks for the commit. I understand your point. We now have at least separate report to monitor the tickets. If non-holiday themes comes in the report, we will handle manually.

Note: See TracTickets for help on using tickets.