WordPress.org
Get WordPress

Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#3288 closed enhancement (fixed)

WordPress.org theme: change the number of meetups from number to placeholder

Reported by: wolly's profile wolly Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords: needs-patch
Cc:

Description

In this string we have the number of meetups: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-main/front-page.php?marks=100#L100

I'd suggest to change it with a placeholder %s and then number format it for thousands as @dd32 proposed on slack. (We all are optimists)

Change History (5)

#1 @wolly
7 years ago

As suggested by @tobifjellner on slack: make sure _n() is used, in order to get proper handling of plurals.

This ticket was mentioned in ​Slack in #meta by wolly. ​View the logs.
7 years ago

#3 @ocean90
7 years ago

  • Keywords needs-patch added

#4 @SergeyBiryukov
7 years ago

  • Summary changed from Wordpress.org child theme, change the number of meetup from number to placeholder to WordPress.org theme: change the number of meetups from number to placeholder

#5 @obenland
7 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 6333:

Main: Detach number of meetups from string

Allows for the number of meetups to change without having to translate the string again.

Props wolly.
Fixes #3288.

Note: See TracTickets for help on using tickets.