#3310 closed enhancement (fixed)
Cleanup of plugin-single.php and related code
Reported by: | joostdevalk | Owned by: | obenland |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Plugin Directory | Keywords: | has-patch dev-feedback |
Cc: |
Description
The code in the partials plugin-single.php
and section-advanced.php
is slightly unwieldy and not very DRY. This patch aims to fix that.
It also:
- No longer has the containing block for closed plugins' icons.
- Introduces a couple of template functions in
class-template.php
to retrieve messages so we can maintain these in one place. - Cleans up the code style a bit.
Attachments (2)
Change History (8)
#1
@
7 years ago
Thanks for the patch @joostdevalk. By any chance, is this output from a script of some sort?
Most of the alignment and whitespace changes in class-template.php
are not conforming to existing code styling guidelines as I understand them.
Would you mind resubmitting a patch without them?
This ticket was mentioned in Slack in #meta by joostdevalk. View the logs.
7 years ago
Note: See
TracTickets for help on using
tickets.
Cleanup patch