WordPress.org

Making WordPress.org

Opened 8 months ago

Closed 6 months ago

#3311 closed defect (fixed)

Gutenberg Theme: Links in list are not underlined

Reported by: Soean Owned by: obenland
Milestone: Priority: normal
Component: General Keywords: needs-patch
Cc:

Description

On wordpress.org only links in paragraphs are underlined. If you put them into a list, there is no underline. For example, see the resources list at the end of the page: https://wordpress.org/gutenberg/

Attachments (2)

list_links.png (46.3 KB) - added by Soean 8 months ago.
example links
list_links_visited.png (40.7 KB) - added by Soean 8 months ago.
example links visited

Download all attachments as: .zip

Change History (9)

@Soean
8 months ago

example links

@Soean
8 months ago

example links visited

#1 @obenland
7 months ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#2 @obenland
7 months ago

  • Owner changed from karmatosed to obenland
  • Summary changed from Links in list are nor underlined to Gutenberg Theme: Links in list are not underlined

#3 @Soean
7 months ago

@obenland I think its a wp.org global bug in wp4.css, not just in the gutenberg theme.
Other example: https://wordpress.org/about/etiquette/

#4 @chetan200891
7 months ago

It's little difficult to create patch for wp4.css. If we use any of this class to add CSS "#pagebody a", ".wrapper a", "ul li a", that is overriding everywhere. @obenland What's your suggestion for this?

#5 @obenland
7 months ago

I think its a wp.org global bug in wp4.css, not just in the gutenberg theme.

Oh, based on the ticket description I assumed this was about the Gutenberg theme.

It is very difficult to change these kinds of things in wp4.css since it's loaded on all of dotorg. Additionally, in this case, the style directives in question are very broad, which doesn't help either.

They are much easier fixed in a more narrow scope, on a specific site, ideally making wp4 styles unnecessary (like in wporg and wporg-main).

#6 @obenland
6 months ago

Yeah, I'm not going to touch wp4.css, there are just too many unknowns about changing that. But I'll fix it for the Gutenberg theme.

#7 @obenland
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 6436:

Gutenberg: Underline links in content and lists.

Props Soean.
Fixes #3311.

Note: See TracTickets for help on using tickets.