Plugin Checksum generation failing with filenames containing whitespace

[krisshannon]

Filenames with whitespace are being truncated at the first whitespace.

[dd32]

Hey @krisshannon,

Do you have an example plugin of where this is occurring?

[krisshannon]

​https://wordpress.org/plugins/hummingbird-performance/

Specifically version 1.7.0.3 has a file called "externals/shared-ui/font/WPMU DEV Dashboard.json" but the checksum is recorded with a filename of "externals/shared-ui/font/WPMU"

[schlessera]

Link to checksums of this plugin & version: ​https://downloads.wordpress.org/plugin-checksums/hummingbird-performance/1.7.0.3.json

Indeed, the filename was truncated at the first space.

[dd32]

In 6280:

Plugin Directory: Checksums: Correctly handle filenames with spaces, previously the filename was being truncated.

Props krisshannon.
Fixes #3335.

[krisshannon]

Hey @dd32

What if the plugin includes both a 'Testing' file as well as 'Testing Test'? If there is a new checksum for the 'Testing' file the old one will be lost.

Maybe the if ( isset( $skip_bad_files[ $file ] ) ) block should be moved inside the if ( ! isset( $json_checksum_file->files[ $file ] ) ) block.

[dd32]

Good call @krisshannon - If this runs into any further problems I'm just going to remove the skip function though :)

[dd32]

In 6281:

Plugin Directory: Checksums: Move the $skip_bad_files into the non-existant file branch to avoid accidentally clobbering a real file.

Props krisshannon.
Fixes #3335.

[schlessera]

@dd32 The checksums in ​https://downloads.wordpress.org/plugin-checksums/wd-instagram-feed/1.2.9 still contain a truncated filename ( see ​https://make.wordpress.org/cli/2017/12/09/call-for-action-help-us-test-checksum-verification/#comment-102 ).

Has this simply not been updated yet, or do you think we still have a problem with the generation.

The difference this time is that the file contains URL encoded spaces (%20) instead of actual spaces.

[schlessera]

Apparently, this is fixed in the following release's checksums file, so I assume the problem is just that older versions don't get recreated.

[dd32]

Replying to schlessera:

@dd32 The checksums in ​https://downloads.wordpress.org/plugin-checksums/wd-instagram-feed/1.2.9 still contain a truncated filename ( see ​https://make.wordpress.org/cli/2017/12/09/call-for-action-help-us-test-checksum-verification/#comment-102 ).

You'll need to report any truncated checksums, they won't be fixed retrospectively automatically unless there's a change to the plugin version.
Please post the filename of the truncated files too, as I'm not going to dig through the files to verify if it's fixed or not.
I've kicked off a job to rebuild the ZIPs (and therefor, checksums) of the mentioned plugin.