Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3336 closed defect (bug) (fixed)

Themes: Use Cavalcade for Trac sync

Reported by: obenland's profile obenland Owned by: obenland's profile obenland
Milestone: Priority: normal
Component: Theme Directory Keywords: has-patch dev-feedback


Ever since the Theme Directory was updated two or three years ago, the script that syncs theme review results over to the directory has been running as a cronjob on my sandbox.

With the introduction of Cavalcade on, this is no longer necessary and it should be moved over.

Attachments (1)

3336.diff (7.2 KB) - added by obenland 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @Otto42
6 years ago

Agreed. How often does the cron job run?

6 years ago

#2 @obenland
6 years ago

Agreed. How often does the cron job run?

Every 15 minutes

#3 @obenland
6 years ago

  • Keywords has-patch dev-feedback added

3336.diff is largely based off of the way the plugin directory jobs work.

@dd32 would you mind reviewing that diff?
Props go to @noisysocks, @bpayton, @tellyworth, and I.

#4 @dd32
6 years ago

Overall it looks fine to me.

  • I'd probably reduce theme_directory_check_cronjobs to every 15m, it's not as crucial as on the plugin directory where there's many events per minute that need managing / catching if they fail.
  • Rather than require_once WP_PLUGIN_DIR . '/theme-directory/lib/class-trac.php' I'd use require_once dirname( __DIR__ ) . '/lib/class-trac.php';

#5 @obenland
6 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 6289:

Themes: Use Cavalcade for Trac sync.

Props tellyworth, noisysocks, bpayton, obenland, dd32.
Fixes #3336.

#6 @obenland
6 years ago

In 6290:

Themes: Use proper namespace for WP_Query

See #3336.

#7 @obenland
6 years ago

In 6295:

Themes: Use get_post rather than WP_Query.

Makes this sync script actually work.

See #3336.

Note: See TracTickets for help on using tickets.