WordPress.org

Making WordPress.org

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#3337 closed defect (fixed)

Showcase loading different scripts

Reported by: xkon Owned by: dd32
Milestone: Priority: normal
Component: Showcase Keywords:
Cc:

Description

After seeing the #1173 going live I went on to check it out but I saw what is probably a cache issue.

I'm making this ticket here after a little chat with @dd32 to check it further if / when possible.

There's a different 'scripts.js' loading when logged in ( Chrome dev tools ) and when not ( FF dev tools ). This makes the new Showcase hamburger menu not working if you are logged in basically.

Screenshot shows a comparison on logged in / logged out. The right side script ( chrome ) should be the correct one loading at the time being that has the menus function.

Attachments (1)

script_js_showcase.png (81.5 KB) - added by xkon 16 months ago.
ff loged in / chrome loged out (correct js)

Download all attachments as: .zip

Change History (3)

@xkon
16 months ago

ff loged in / chrome loged out (correct js)

#1 @dd32
16 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 6282:

Showcase: Bump scripts version for cache busting.

Fixes #3337

#2 @dd32
16 months ago

  • Keywords 2nd-opinion needs-patch removed

Was just a cache race condition - the JS change occurred in the same deploy as the cache buster bump, which caused the old script to get cached with the new version number on one of the load balancers:

$ for i in {249..250}; do curl 'https://wordpress.org/showcase/wp-content/themes/pub/wporg-showcase/js/scripts.js?ver=20171214' --resolve wordpress.org:443:66.155.40.$i --silent | md5sum; done
a652222d9fc0fdd9e5aefb44e4ed5525  -
8e9cff3379971d38ac0f2713c67ff57e  -

$ svn ci && deploy ...

$ for i in {249..250}; do curl 'https://wordpress.org/showcase/wp-content/themes/pub/wporg-showcase/js/scripts.js?ver=20171214a' --resolve wordpress.org:443:66.155.40.$i --silent | md5sum; done
8e9cff3379971d38ac0f2713c67ff57e  -
8e9cff3379971d38ac0f2713c67ff57e  -
Note: See TracTickets for help on using tickets.