WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3364 closed defect (fixed)

Fix the .org site search button

Reported by: afercia Owned by:
Milestone: Priority: normal
Component: General Keywords: has-screenshots
Cc:

Description

Empty buttons or links should always be avoided, as they're interactive UI controls and can't be empty. Buttons are expected to have a text, as well as links. If they're empty, while visually they may work, there's really nothing assistive technologies can announce to users. Just resounding silence.

In the .org site header, the search button uses a "lens" icon but it's empty and gets announced just as "button": users have no clue what the button is for.

https://cldup.com/YOkUSLlZzF.png

Adding a visually hidden text, or an aria-label attribute with meaningful text, would solve the issue. Text would be preferred, as it would work also for devices and software that dont understand ARIA.

Change History (4)

#1 @obenland
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This ticket was mentioned in Slack in #meta by afercia. View the logs.


2 years ago

#3 @afercia
2 years ago

Thanks! Unfortunately, I don't have access to see the changeset.

#4 @obenland
2 years ago

Like mentioned in Slack, the header is unfortunately not open sourced yet, so this was meant more "for the record".

Note: See TracTickets for help on using tickets.