Fix the .org site search button

[afercia]

Empty buttons or links should always be avoided, as they're interactive UI controls and can't be empty. Buttons are expected to have a text, as well as links. If they're empty, while visually they may work, there's really nothing assistive technologies can announce to users. Just resounding silence.

In the .org site header, the search button uses a "lens" icon but it's empty and gets announced just as "button": users have no clue what the button is for.

Adding a visually hidden text, or an aria-label attribute with meaningful text, would solve the issue. Text would be preferred, as it would work also for devices and software that dont understand ARIA.

[obenland]

Fixed in ​https://dotorg.trac.wordpress.org/changeset/13739.

[afercia]

Thanks! Unfortunately, I don't have access to see the changeset.

[obenland]

Like mentioned in Slack, the header is unfortunately not open sourced yet, so this was meant more "for the record".