"Installation Instructions" string is imported for plugins that don't have it

[SergeyBiryukov]

Since [5253], plugin FAQ section is prefixed with "Installation Instructions" string.

That string ends up imported into GlotPress project for the plugin, ​see an example.

If the string does not exist in the ​plugin readme, it should not be imported into its GlotPress project.

[obenland]

So you're saying it should offer "Installation" as a translatable string rather than "Installation Instructions"?

[ocean90]

This is currently working as expected. See https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/class-parser.php#L356 and https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/i18n/class-readme-import.php for the importer.

All strings on the plugin page (​https://ru.wordpress.org/plugins/display-active-plugins-first/) are parsed again and directly searched in GlotPress so the string needs to be in the project.

[SergeyBiryukov]

Replying to ocean90:

All strings on the plugin page (​https://ru.wordpress.org/plugins/display-active-plugins-first/) are parsed again and directly searched in GlotPress so the string needs to be in the project.

But the string is the same for all plugins, and is a part of the Plugin Directory UI rather then readme content. Why does it have to be translated in each project over and over again? The ​Consistency tool shows 11 different translations for ru_RU.

[SergeyBiryukov]

Replying to obenland:

So you're saying it should offer "Installation" as a translatable string rather than "Installation Instructions"?

"Installation" is already offered for translation in the ​Plugin Directory project.

"Installation Instructions" is a part of the same UI, but due to the current implementation it ends up being translated in each plugin project separately. As noted in comment:4, I don't see a point in that, it just adds a bit more work for translators :)

[SergeyBiryukov]

Still thinking the readme importer should skip this string per the comments above.

Marking as maybelater pending a patch.