WordPress.org

Making WordPress.org

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#3523 closed defect (fixed)

Fix mobile nav menu for /plugins and /themes

Reported by: raajtram Owned by: dd32
Milestone: Priority: normal
Component: General Keywords: has-patch needs-testing
Cc:

Description

The navigation menu on current WordPress Themes and WordPress Plugins pages (and the sub-pages/directories) doesn't toggle when clicked upon (on screens <768px, of course).

The CSS provided for it has some bugs. I compared it to the main wp.org page to get the correct CSS for the same.

I've created a patch (my first ever!) to fix this. Please let me know if I'm doing this (submitting a patch bit) right. Thank you!

The patch is for the /sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/css/components/_wporg-header.scss file.

Attachments (1)

_wporg-header.patch (299 bytes) - added by raajtram 19 months ago.
/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/css/components/_wporg-header.scss

Download all attachments as: .zip

Change History (8)

@raajtram
19 months ago

/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/css/components/_wporg-header.scss

This ticket was mentioned in Slack in #meta by raajtram. View the logs.


19 months ago

#2 @danieltj
19 months ago

  • Keywords needs-testing added
  • Priority changed from high to normal

Hi @raajtram and welcome to Trac!

Just a couple of pointers for future reference, a change like this is rather small and minor, so priority wise it probably fits into a normal or low priority level. Furthermore, when creating a patch, generally it's advised that you name the patch file either 3523.diff or 3523.patch. You don't have to, and it's still acceptable to name it how you have, but that is what is generally preferred so it's easier to see what ticket it affects.

I've also tested the patch and it seems to work as expected. Good work! As it's a small fix, it'll probably be able to be committed soon-ish by someone with meta commit access when they're happy with it. Good job!

#3 @raajtram
19 months ago

Duly noted on the priority and file-naming. Makes complete sense. Thanks @danieltj!

#4 @dd32
19 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 6901:

WordPress.org base theme: Correct the SCSS rule for the mobile menu being toggled.

Props raajtram for initial patch.
Fixes #3523.

#5 @dd32
19 months ago

In 6902:

Learn, Main, Plugins, Themes: Update CSS styles following r6901.

See #3523.

#6 @dd32
19 months ago

In 6903:

WordPress.org Base theme, Main, Plugins, Themes: Update style cache-busters following r6902.

See #3523.

#7 @dd32
19 months ago

Thanks!

I tweaked the patch slightly to be more SCSS-like :)

I think I've caught all the locations where that SCSS file was being pulled into.

Note: See TracTickets for help on using tickets.