#3523 closed defect (bug) (fixed)
Fix mobile nav menu for /plugins and /themes
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Component: | General | Keywords: | has-patch needs-testing |
| Cc: |
Description
The navigation menu on current WordPress Themes and WordPress Plugins pages (and the sub-pages/directories) doesn't toggle when clicked upon (on screens <768px, of course).
The CSS provided for it has some bugs. I compared it to the main wp.org page to get the correct CSS for the same.
I've created a patch (my first ever!) to fix this. Please let me know if I'm doing this (submitting a patch bit) right. Thank you!
The patch is for the /sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/css/components/_wporg-header.scss file.
Attachments (1)
Change History (8)
This ticket was mentioned in Slack in #meta by raajtram. View the logs.
7 years ago
#2
@
7 years ago
- Keywords needs-testing added
- Priority changed from high to normal
Hi @raajtram and welcome to Trac!
Just a couple of pointers for future reference, a change like this is rather small and minor, so priority wise it probably fits into a normal or low priority level. Furthermore, when creating a patch, generally it's advised that you name the patch file either 3523.diff or 3523.patch. You don't have to, and it's still acceptable to name it how you have, but that is what is generally preferred so it's easier to see what ticket it affects.
I've also tested the patch and it seems to work as expected. Good work! As it's a small fix, it'll probably be able to be committed soon-ish by someone with meta commit access when they're happy with it. Good job!
#3
@
7 years ago
Duly noted on the priority and file-naming. Makes complete sense. Thanks @danieltj!
/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg/css/components/_wporg-header.scss