WordPress.org

Making WordPress.org

#3569 closed defect (fixed)

WP15 Theme: Allow translators to disable Google Fonts for their language

Reported by: dimadin Owned by: iandunn
Milestone: Priority: normal
Component: General Keywords: has-patch
Cc:

Description

Attached is a patch that takes approach from default WordPress themes. Note that subset query arg takes effect only for browsers that don't support unicode-range.

Attachments (1)

3569.diff (1.8 KB) - added by dimadin 10 months ago.

Download all attachments as: .zip

Change History (5)

@dimadin
10 months ago

#1 @iandunn
10 months ago

@melchoyce, do you have any preferred backup fonts for locales where Crete Round and/or Source Sans Pro are disabled?

#2 @melchoyce
10 months ago

For the sans serif, we'll probably want to look at Twenty Seventeen's font stack. You can't really go wrong with Arial generally.

Crete Round is more of a stylistic choice, so in that case, it really depends on the language/alphabet. I don't want to say "go with a serif," because some alphabets don't necessarily have serifs — and if they do, they don't always look great. (I feel like I remember someone — maybe @ranyanivhartstein? — saying that Hebrew serif fonts were pretty illegible?)

Would love to get some suggestions if we have designers with experience in non-latin alphabets.

#3 @SergeyBiryukov
10 months ago

WordPress core and bundled themes generally use Tahoma for RTL, except for Hebrew, which uses Arial. Twenty Seventeen seems to handle this correctly.

3569.diff looks good to me.

#4 @iandunn
10 months ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 7117:

WP15: Only enqueue fonts for locales that they support.

Props dimadin.
Fixes #3569.

Note: See TracTickets for help on using tickets.