WordPress.org

Making WordPress.org

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#3571 closed enhancement (invalid)

Add background-repeat & background-position in the Plugin directory css

Reported by: mostafa.s1990 Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords: ui-feedback has-screenshots needs-design
Cc:

Description

Hi,

I'm surprised why these 2 values are not added with (https://s.w.org/wp-content/themes/pub/wporg-plugins/css/style.css)

.single .entry-thumbnail .plugin-icon {
    -webkit-background-size: contain!important;
    background-size: contain!important;
    height: 96px!important;
    width: 96px!important;
    background-repeat: no-repeat;
    background-position: center;
}

See the attachment.
http://mostafa-soufi.ir/wp-content/uploads/2018/04/screenshot-wordpress.org-2018.04.14-14-29-31.png

Attachments (1)

screenshot-wordpress.org-2018.04.14-14-29-31.png (137.5 KB) - added by mostafa.s1990 20 months ago.

Download all attachments as: .zip

Change History (4)

#1 follow-up: @Otto42
20 months ago

Well, it's usually not needed, because we expect people to make their icons square.

This icon isn't square: view-source:https://plugins.svn.wordpress.org/wp-statistics/assets/icon.svg

Note the svg header:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 292.12 298.15">

292.12 != 298.15

#2 in reply to: ↑ 1 ; follow-up: @dd32
20 months ago

  • Milestone Plugin Directory v3.0 deleted
  • Resolution set to invalid
  • Status changed from new to closed

The background positioning is deliberately not included, as icons are supposed to tile.

Most plugin icons provided by authors are the correct size, and as a result are square and do not tile like that.

Most geopattern icons are tiled, although some are square, compare:
https://wordpress.org/plugins/geopattern-icon/baztaz.svg (Square, doesn't need to tile, but could)
https://wordpress.org/plugins/geopattern-icon/foobar.svg (Rectangular, tiles vertically)

I'm going to close this one as invalid myself, as we need tiling, and if you make the icon the correct size there's no issues.
(Sidenote: I don't think core does tiling, and instead stretches icons instead incorrectly)

#3 in reply to: ↑ 2 @mostafa.s1990
20 months ago

Thank you @dd32, @Otto42,

The issue solved.

Note: See TracTickets for help on using tickets.