WordPress.org

Making WordPress.org

#3581 closed defect (fixed)

Plugin directory homepage says that it's also available in nothing

Reported by: danieltj Owned by: dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

On the plugin directory homepage, the green translation banner is missing the language locale so it says it's also available in (nothing). I've attached a screenshot of what I mean.

Page: https://wordpress.org/plugins/

Attachments (1)

plugin-directory-bug.png (230.0 KB) - added by danieltj 17 months ago.

Download all attachments as: .zip

Change History (8)

#1 @Otto42
17 months ago

What language are you sending it in your Accept header? What languages does your browser know about?

#2 @danieltj
17 months ago

I'm using Chrome 65. In the request headers, it sent accept-language: en-GB,en-US;q=0.9,en;q=0.8,la;q=0.7.

Hope that helps.

#3 @dd32
17 months ago

In 7124:

Plugin Directory: Locale Banner: Validate that the Locales can be found by wp_locale before attempting to use them.

See #3581.

#4 @dd32
17 months ago

  • Keywords needs-patch removed

This is happening as la is a known locale, but GlotPress doesn't understand it's a wp_locale

The correct fix is to fix GlotPress's locales.php to include the wp_locale like most other languages. That will also allow us to set the la.wordpress.org's site language to la.

https://github.com/GlotPress/GlotPress-WP/blob/develop/locales/locales.php#L1314-L1321

The other fix is to validate that all the GP_Locale's can be found via that wp_locale as per [7124]

#5 @dd32
17 months ago

In 7125:

Plugin Directory: Locale Header: Don't fall into the "This plugin isn't yet translated" branch when no plugin is specified.

See #3581.

#6 @obenland
16 months ago

  • Owner set to dd32
  • Status changed from new to assigned

Can this be closed?

#7 @dd32
16 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

It's fixed well enough on our side to close :)

Note: See TracTickets for help on using tickets.