Opened 6 years ago

Closed 5 years ago

#3598 closed defect (bug) (fixed)

CampSite 2017: Rename mobile menu labels to "Menu"

Reported by: melchoyce's profile melchoyce Owned by: vedjain's profile vedjain
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: commit


Currently on mobile, the menus are labelled by their positions — which doesn't make sense for site viewers, who don't have any context around menu locations. We should relabel them "Menu."

Attachments (3)

Screen Shot 2018-05-01 at 1.47.10 PM.png (90.5 KB) - added by melchoyce 6 years ago.
Screen Shot 2018-05-01 at 1.47.16 PM.png (64.4 KB) - added by melchoyce 6 years ago.
3598.patch (1.3 KB) - added by ryelle 5 years ago.

Download all attachments as: .zip

Change History (10)

#1 @iandunn
5 years ago

  • Keywords needs-patch good-first-bug added
  • Status changed from new to assigned

FTR that's using the CampSite-2017 theme.

I agree that it shouldn't have "secondary" or other location labels in it.

#2 @iandunn
5 years ago

Although, the primary and secondary menus are pretty close to each other, so if they're both used, then the user might be confused about whether or not they're the same, and which one contains the items they're looking for. I'm not sure if there's a better solution, though, because "primary" and "secondary" won't really give the user the information they need in that case either.

#3 @melchoyce
5 years ago

Could we use the user-defined menu names? Then it's up to the camp to come up with something that makes the most sense based on their content.

5 years ago

#4 @ryelle
5 years ago

  • Keywords has-patch added; needs-patch removed

3598.patch uses the menu name set for the given location, so WC organizers can name the menus themselves (so if Secondary was social links, it can be called that, etc).

This ticket was mentioned in Slack in #meta-wordcamp by ryelle. View the logs.

5 years ago

#6 @iandunn
5 years ago

  • Keywords commit added; good-first-bug has-patch removed

#7 @vedjain
5 years ago

  • Owner set to vedjain
  • Resolution set to fixed
  • Status changed from assigned to closed

In 8747:

WC Campsite2017: Use menu names to make it more useful for visitors

Earlier, on mobile, menus were labelled by their positions, i.e. Primary or Secondary, which does not really makes sense for a visitor.
This patch uses the actual menu names to label a menu, so that organizers can come up with names that makes most sense depending upon content, for egs, Socials, Pages etc.

fixes #3598
props ryelle

Note: See TracTickets for help on using tickets.