Making WordPress.org

Opened 12 months ago

Last modified 3 days ago

#3598 assigned defect

CampSite 2017: Rename mobile menu labels to "Menu"

Reported by: melchoyce Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: commit


Currently on mobile, the menus are labelled by their positions — which doesn't make sense for site viewers, who don't have any context around menu locations. We should relabel them "Menu."

Attachments (3)

Screen Shot 2018-05-01 at 1.47.10 PM.png (90.5 KB) - added by melchoyce 12 months ago.
Screen Shot 2018-05-01 at 1.47.16 PM.png (64.4 KB) - added by melchoyce 12 months ago.
3598.patch (1.3 KB) - added by ryelle 3 days ago.

Download all attachments as: .zip

Change History (9)

#1 @iandunn
3 days ago

  • Keywords needs-patch good-first-bug added
  • Status changed from new to assigned

FTR that's https://2018.boston.wordcamp.org/ using the CampSite-2017 theme.

I agree that it shouldn't have "secondary" or other location labels in it.

#2 @iandunn
3 days ago

Although, the primary and secondary menus are pretty close to each other, so if they're both used, then the user might be confused about whether or not they're the same, and which one contains the items they're looking for. I'm not sure if there's a better solution, though, because "primary" and "secondary" won't really give the user the information they need in that case either.

#3 @melchoyce
3 days ago

Could we use the user-defined menu names? Then it's up to the camp to come up with something that makes the most sense based on their content.

3 days ago

#4 @ryelle
3 days ago

  • Keywords has-patch added; needs-patch removed

3598.patch uses the menu name set for the given location, so WC organizers can name the menus themselves (so if Secondary was social links, it can be called that, etc).

This ticket was mentioned in Slack in #meta-wordcamp by ryelle. View the logs.

3 days ago

#6 @iandunn
3 days ago

  • Keywords commit added; good-first-bug has-patch removed
Note: See TracTickets for help on using tickets.