GlotPress negative counts

[GaryJ]

• ​https://translate.wordpress.org/locale/en-gb/default/wp-plugins/uptime-robot-widget has -3
• ​https://translate.wordpress.org/locale/en-gb/default/wp-plugins/agile-store-locator has -1.
• ​https://translate.wordpress.org/locale/en-gb/default/wp-plugins/pods has -24.

These should all be 0.

[obenland]

In 7444:

Translate: There can't be a translation backlog of less than 0.

Props GaryJ.
Fixes #3713.

[garrett-eclipse]

THANK YOU, I run into this ALL the time

[GaryJ]

I don't deserve props for anything here!

While this fixes the symptom, is there any underlying cause that needs addressing? i.e. why is current_count somehow ending up more than all_count in the first place?

My suspicion is that it comes from a situation like this:

• someone submits a string.
• they then realise they made a mistake, and so submits a replacement string. There are now two strings Waiting.
• a PTE/GTE comes along, and bulk approves all the strings (without appreciating that they are not all for unique original strings).

If the strings had been approved one by one, then I think there would be warnings when trying to approve the second submission. However, there's no such visual warning for bulk approvals, so there may not be the same checks going on, or at least the counts logic isn't taking into consideration that bulk approving 100 strings may not result in 100 approved strings, like when the situation above occurs, for instance.

[garrett-eclipse]

Might want to check with @ocean90 if this is a GlotPress issue or just translate.wp.org as it might be better address in GlotPress itself;
​https://github.com/GlotPress/GlotPress-WP/issues

[GaryJ]

I did originally raise these three instances of negative counts with @ocean90 before, but he hadn't had a chance to address them, as he had with other instances. @pento said to open a Meta ticket for these three, which is this one.

[garrett-eclipse]

Ah good stuff, sounds like it's under control

[ocean90]

In 7480:

Translate: Revert [7444] due to not fixing the actual issue.

See #3713.

[ocean90]

This is a known issue with an unknown cause through. In case you find another set with a negative number just comment here with a link and someone will clear the duplicates.

[garrett-eclipse]

Hi @ocean90 I've got another instance here and did some snooping to see if I could help shed some light on the cause.

Plugin Project;
​https://translate.wordpress.org/locale/en-ca/default/wp-plugins/wc-product-customer-list

Note the Stable (latest release) has the -1 count.

Comparing the two Stable vs Development I noted Stable has 145 (one more) and Develop has 144.

I then found the specific case which shows as a duplicate in stable and not develop;
​https://i.imgur.com/jZB8ySD.png

Looking at 'All translations of this original' on both the duplicate strings in stable;
​https://translate.wordpress.org/projects/wp-plugins/wc-product-customer-list/stable/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=2543415&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc
​https://translate.wordpress.org/projects/wp-plugins/wc-product-customer-list/stable/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=2543415&sort%5Bby%5D=translation_date_added&sort%5Bhow%5D=asc
*They're identical with the same original_id.

And in the 'View original in consistency tool' you see three entries one from develop and the two duplicates from stable;
​https://translate.wordpress.org/consistency?search=Shipping+address+1+column&set=en-ca%2Fdefault
*note times... The develop string was added a second before BOTH the develop duplicate strings which leads me to believe the Develop version was translated and then the sync process created a duplicate in the mirrored stable branch.

This seems to be consistent with how I recall creating the issue is I would submit a string or approve one on develop and then would find the negative counts applied to the stable branch.

Anyway what I'm getting at is it seems to be an issue with the syncing of strings between dev/stable.

[garrett-eclipse]

Hi @ocean90 can you clear out the negative on TEC Stable;
​https://translate.wordpress.org/locale/en-ca/default/wp-plugins/the-events-calendar
Thanks

[garrett-eclipse]

Another one here;
​https://translate.wordpress.org/locale/en-ca/default/wp-plugins/wp-smushit

[GaryJ]

Another one here:

​https://translate.wordpress.org/locale/en-gb/default/wp-plugins/liveblog

[garrett-eclipse]

Another with a huge negative;
​https://translate.wordpress.org/locale/en-nz/default/wp-plugins/paid-member-subscriptions

And on the project's all locale view it's at 111%;
​https://translate.wordpress.org/projects/wp-plugins/paid-member-subscriptions

Screen - ​https://i.imgur.com/s645e9H.png

[ocean90]

Based on any new reports I'm going to close this as worksforme.

[garrett-eclipse]

Sound good @ocean90 I just quickly ran through all the projects linked here that had the issue originally and can confirm there's none with a negative.