Frontenberg broken on Rosetta websites: Block "core/shortcode" is not registered.

[audrasjb]

Hello,

Hello, fronteberg seems to be broken.
This error appear in browser console: Block "core/shortcode" is not registered.
Examples:

• WordPress.org: ​https://wordpress.org/gutenberg
• Rosetta: ​https://fr.wordpress.org/gutenberg

[audrasjb]

The issue seems to be fixed now, thanks :)

[garrett-eclipse]

This issue continues to persist and seems to be a RACE condition so doesn't always surface

[aduth]

Still seeing this happen as of today, August 3, 2018.

I ​commented in Slack with a suspected cause.

The white screen is caused by this line: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/gutenberg/functions.php?rev=7584#L158
Probably a race condition with the initialization of the editor, which is slightly more involved ​https://github.com/WordPress/gutenberg/blob/9ae5aa223ef80c48f2352e4b90ffaefc37bc5258/lib/client-assets.php#L1292-L1298
Instead of wp.domReady, it should probably be using window._wpLoadGutenbergEditor.then

Edit: To clarify, the race condition is that it is initializeEditor which registers the core set of blocks:

​https://github.com/WordPress/gutenberg/blob/9ae5aa223ef80c48f2352e4b90ffaefc37bc5258/edit-post/index.js#L70

I suspect that what is happening is that the wp.api.init in Gutenberg's own initialization is slightly more delayed than the wp.domReady in the gutenberg frontend theme, so it's attempting to unregister the block before it's yet been registered.

[obenland]

In 7592:

Gutenberg: Don't unregister block until after editor initialized.

Props randerson, aduth.
See #3735.

[dd32]

In 7593:

Gutenberg: Override wp.domReady with a version which doesn't contain a race-condition, this fixes the whitescreen on frontendberg on first load.

wp.domReady() is incorrectly regisering callbacks (such as the Gutenberg init function) to be fired on DOMContentLoaded AFTER that event has already fired, causing the callbacks to never run.
This replaces it with a version which does work, calling the callback immediately when document.readyState is at interactive (which is what fires DOMContentLoaded) or complete (when styles/images/etc are loaded, which the Gutenberg wp.domReady does).

See #3703, #3735.