WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 4 days ago

#3784 closed defect (reported-upstream)

i18n: numbered placeholders for notify_applicant_application_received

Reported by: felipeelia Owned by: vedjain
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch
Cc:

Description

In notify_applicant_application_received function (sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-event/class-event-application.php) we should:

1 - Have numbered placeholders.
2 - Update translators comment.

So, this

//translators: Name and city of the event. Egs WordCamp in New York.
$message = sprintf(
        __(
                "Thank you for applying to organize a %s in %s! We'll send you a follow-up e-mail once we've had a chance to review your application.",
                'wpct'
        ),
        $this->get_event_label(), sanitize_text_field( $meetup_city )
);

Should actually become something like:

/* translators: 1: Name of the event. 2: City of the event. */
$message = sprintf(
        __(
                'Thank you for applying to organize a %1$s in %2$s! We'll send you a follow-up e-mail once we've had a chance to review your application.',
                'wpct'
        ),
        $this->get_event_label(), sanitize_text_field( $meetup_city )
);

Change History (3)

#1 @coreymckrill
2 years ago

  • Keywords needs-patch added
  • Owner set to vedjain
  • Status changed from new to assigned

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


5 months ago

#3 @dd32
4 days ago

  • Resolution set to reported-upstream
  • Status changed from assigned to closed

This ticket has been moved to GitHub https://github.com/WordPress/wordcamp.org/issues/603

Note: See TracTickets for help on using tickets.