Making WordPress.org

Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#3800 closed enhancement (fixed)

Highlight new ticket on Trac

Reported by: mukesh27 Owned by: dd32
Milestone: Priority: normal
Component: Trac Keywords: ui-feedback has-screenshots needs-patch


Need to highlight *New Ticket* on Trac website https://make.wordpress.org/core/reports/ so user can easily find that and create new ticket.

Attachments (4)

old_ticket_design.png (18.9 KB) - added by mukesh27 22 months ago.
new_ticket_design.png (19.0 KB) - added by mukesh27 22 months ago.
Screen Shot 2018-09-14 at 1.40.56 pm.png (17.4 KB) - added by dd32 22 months ago.
New ticket button is the far right icon
Screen Shot 2018-09-14 at 1.43.15 pm.png (211.7 KB) - added by dd32 22 months ago.

Download all attachments as: .zip

Change History (12)

#1 @mukesh27
22 months ago

  • Keywords has-screenshots added

#2 @mukesh27
22 months ago

  • Type changed from defect to enhancement

22 months ago

New ticket button is the far right icon

#3 follow-up: @dd32
22 months ago

Just noting that the screenshots here are from https://core.trac.wordpress.org/tickets/latest

From what I can tell, I think that button was added in the recent Trac updates, as it's not linking correctly to the new ticket page as the icon in the main menu is (See above screenshot).

I think we should probably just hide/remove that button completely, leaving the above link which redirects through the login forms.

#4 @dd32
22 months ago

Additionally, as seen above, that "New Ticket" button also appears on the new ticket page itself, although with the correct styling. Seems a bit out of place to me..

#5 in reply to: ↑ 3 @dd32
22 months ago

  • Keywords needs-patch added; 2nd-opinion removed

Replying to dd32:

From what I can tell, I think that button was added in the recent Trac update

Scratch that, it was present before. Most of the default menu items are hidden on core.trac, however that singular button was re-added 3 years ago:

Trac: Have 'New Ticket' nav menu item show on Core Trac to temporarily resolve feedback that it cannot be found.

The current styling is "correct", as it's a menu item and not a button - as weird as it looks.

I guess as it's the only link in the menu we can just treat it as a button and stylise it as such.

#6 @mukesh27
22 months ago

@dd32 so that New Ticket button have to removed from now?

Also we have to change new ticket icon links to normal so that it will not redirect any logged in user to https://login.wordpress.org/?redirect_to=https://core.trac.wordpress.org/newticket then redirect to new ticket page.

#7 @dd32
22 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 7679:

Trac: Core: Treat the New Ticket button as always being "active" to make it appear like a button rather than a stray link.

H/t mukesh27.
Fixes #3800.

#8 @dd32
22 months ago

In 7680:

Trac: Cache buster bump for [7679].

Fixes #3800.

Note: See TracTickets for help on using tickets.