Editing Descriptions that contain emoji's strip the emoji

[garrett-eclipse]

Hello,

As @SergeyBiryukov found here - ​https://core.trac.wordpress.org/ticket/44987#comment:3

The emoji's within Trac Ticket descriptions get stripped from the description edit field.

Example - ​https://core.trac.wordpress.org/ticket/43354

To reproduce without muddying the ticket simply put your cursor in the description field and wait for the JS to reload the ticket contents and you'll find the emoji stripped. Or if you just look in the description field you'll find no characters within it representing the emoji.

Cheers

---

✅👍🎉

[garrett-eclipse]

Ticket w/ Emoji

[garrett-eclipse]

Same ticket with stripped emoji

[ocean90]

#4515 was marked as a duplicate.

[dd32]

Turns out that this isn't even a Trac bug, it's a combination Twemoji or WordPress Emoji issue.

The tl;dr of it is, the ​WordPress Emoji MutationObserver calls twemoji.parse() with a textarea node, which causes twemoji.grabAllTextNodes() to fetch all the subnodes of a textarea node, and not skip textarea as it "should".

I'm debating on if it's a twemoji or WordPress Emoji bug (leaning towards the latter) as I think twemoji is doing exactly what is wanted, processing Emoji's within an element that's usually skipped but doing so because it's been told to process that exact node.
On the other hand, maybe it's unexpected that passing a skipped node to twemoji.parse() should process it..

[dd32]

After chatting with Gary, I decided to just add the wp-exclude-emoji class to the textareas in Trac, I have a WIP patch for that.. but it needs some more testing

[dd32]

In 9022:

Trac: Add the wp-exclude-emoji class to the ticket description and comment textareas to avoid WordPress emoji converting emoji's to <img> which strips them from the textarea.

Fixes #3838.

[dd32]

Just adding some Emoji ✅👍🎉

[dd32]

and editing the Description with Emoji

[garrett-eclipse]

Thanks @dd32 seems to work nicely on core Trac as well.

[dd32]

In 9023:

Trac: Update the WordPress Emoji code to the latest version.
This also upgrades to using Twemoji v12 rather than v11.2.

See #3838.