WordPress.org

Making WordPress.org

Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#3840 closed defect (fixed)

Search Page (while searching from gutenberg demo page) is not properly styled.

Reported by: manishamakhija Owned by: coffee2code
Milestone: Priority: normal
Component: General Keywords: has-screenshots ui-feedback needs-design has-patch
Cc:

Description

While doing search in https://wordpress.org/gutenberg/ page. I came across the search page which is not styled properly. I think it should be design like other search pages like the title should be left align.

Attachments (4)

search-btn.png (84.1 KB) - added by manishamakhija 10 months ago.
gutenberg-search-page.png (113.0 KB) - added by manishamakhija 10 months ago.
Search Results for “taxonomy” – The new Gutenberg editing experience — WordPress.png (120.8 KB) - added by manishamakhija 10 months ago.
3840.patch (588 bytes) - added by mukesh27 10 months ago.
Possible fix.

Download all attachments as: .zip

Change History (11)

#1 follow-up: @manishamakhija
10 months ago

Also the active link color of title should be of different color

#2 @mukesh27
10 months ago

  • Milestone Improved Search deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Hi @manishamakhija, Welcome to Meta WordPress Trac! Thank you for testing Gutenberg.

Good cache. By mistake i set it close.

Last edited 10 months ago by mukesh27 (previous) (diff)

#3 @manishamakhija
10 months ago

  • Resolution maybelater deleted
  • Status changed from closed to reopened

Hi @mukesh27, Thanks for viewing and analyzing this ticket.

The search page is accessible to end user, please check the first screenshot I've attached previously. Search field is on the top rightmost corner. I'm attaching the screenshot having search query in it.

#4 @mukesh27
10 months ago

  • Keywords ui-feedback needs-design added

Hi @manishamakhija, sorry i missed that. It's bug in design.

Added design feedback so core designer take care search page design.

@mukesh27
10 months ago

Possible fix.

#5 @mukesh27
10 months ago

  • Keywords has-patch added

Hi @dd32, can you please check this ticket as it's need one minor css fix. i have added patch to fixed that css issue.

#6 @coffee2code
9 months ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from reopened to closed

In 7782:

Gutenberg: Add some basic styling to search results page.

Props mukesh27, coffee2code.
Fixes #3840.

#7 in reply to: ↑ 1 @coffee2code
9 months ago

Replying to manishamakhija:

Also the active link color of title should be of different color

For clarification, I think you're suggesting that the color for visited links should get changed, seeing as they are defined as a:visited { color: #333 }, which isn't too far off the regular text color of #444. I'm not sure why they aren't some shade of blue.

Anyhow, link colors are a more general recommendation for the site rather than just the search results page, so it warrants its own ticket if you want to continue pursuing it. However, I did add an underline to links on the search results page, which better differentiates them from regular text somewhat.

Note: See TracTickets for help on using tickets.