WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 6 months ago

#3844 closed defect (fixed)

Circular reference in plugin SVN

Reported by: kdickinson Owned by:
Milestone: Priority: low
Component: Version Control Keywords:
Cc:

Description

I have encountered some kind of circular reference issue with a particular plugin hosted on your subversion.

You can validate this issue via the following command:
svn checkout https://plugins.svn.wordpress.org/dev-content-blocks/tags/1.4/

You will see output that looks increasingly self-referencing, eg:

Fetching external item into '1.4/dev-content-blocks/tags/1.4/dev-content-blocks/tags/1.4/dev-content-blocks/tags/1.4/dev-content-blocks':

Change History (6)

#1 @Otto42
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#3 @kdickinson
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I have identified another issue here:

/tmp/tmpg0d92069/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/tags/0.3.8/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/languages/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/css/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/trunk/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/tags/0.3.8/class/mfp-mod-wp/

Version 0, edited 3 years ago by kdickinson (next)

#4 follow-up: @dd32
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Removed the svn:externals from mfp-mod-wp.

WordPress.org ignores externals, you'd be best using --ignore-externals.

You'd also be better not using SVN at all, using either the WordPress plugins API to get the latest ZIP and download that directly, or using this zip url to get the latest release: https://downloads.wordpress.org/plugin/{$slug}.latest-stable.zip ie https://downloads.wordpress.org/plugin/mfp-mod-wp.latest-stable.zip

#5 in reply to: ↑ 4 ; follow-up: @Andrea Gelmini
6 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi guys,

and thanks a lot for your work!

Replying to dd32:

Removed the svn:externals from mfp-mod-wp.

I still see the issue. I can replicate it on different machines.
If I do "svn co https://svn.wp-plugins.org/mfp-mod-wp/", it never stops.

Same thing for this:
https://svn.wp-plugins.org/webinar-ignition

WordPress.org ignores externals, you'd be best using --ignore-externals.

Really? I found a few plugings with dependecies from external libraries. So, I guess they need it.

Thanks a log,
Gelma

#6 in reply to: ↑ 5 @dd32
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to Andrea Gelmini:

Replying to dd32:

Removed the svn:externals from mfp-mod-wp.

I still see the issue. I can replicate it on different machines.
If I do "svn co https://svn.wp-plugins.org/mfp-mod-wp/", it never stops.

It appears that I didn't remove them all in https://plugins.trac.wordpress.org/changeset/1951653, so I've removed the rest in
https://plugins.trac.wordpress.org/changeset/2542414

Same thing for this:
https://svn.wp-plugins.org/webinar-ignition

Fixed that one too in https://plugins.trac.wordpress.org/changeset/2542417

WordPress.org ignores externals, you'd be best using --ignore-externals.

Really? I found a few plugings with dependecies from external libraries. So, I guess they need it.

It's never been supported, anything that's using it and relying upon it is broken and has been for a loooong time.

We won't be enabling it at all, and all automated svn processes on WordPress.org include --ignore-externals for this reason.

Please update your URLs too, plugins.svn.wordpress.org is the hostname now, not svn.wp-plugins.org which hasn't been used in a long time either :)

Additionally, if you're finding random plugins like this, that probably means you're checking out a of of plugins, please consider not using SVN for that, and using either https://wpdirectory.net/ or https://github.com/markjaquith/WordPress-Plugin-Directory-Slurper

Note: See TracTickets for help on using tickets.