Opened 8 years ago
Last modified 7 weeks ago
#3858 reviewing defect (bug)
Fix/add select2 support to HelpHub Contributors module
| Reported by: | dd32 | Owned by: | netweb |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | HelpHub (wordpress.org/documentation) | Keywords: | has-patch |
| Cc: |
Description
Currently HelpHub's Contributor module is enqueueing a non-existent select2 js file on all admin screens causing console errors :)
It shouldn't be enqueued on all admin screens either if avoidable.
Change History (5)
This ticket was mentioned in PR #647 on WordPress/wordpress.org by @yani.iliev.
3 months ago
#4
- Keywords has-patch added
## Summary
Two post-deploy polish fixes on the /pledges/ Find Me feature shipped in #646, found via live design review on make.wordpress.org/meta/pledges/.
### 1. Clear-filters button: dark-blue text on near-black pill
The Clear filters button — used both inside the filtered-out standing card ("You're hidden by current filters." card) and inside the empty-state card — was rendering as dark-blue text on a charcoal-1 pill. The theme's .entry-content a { color: #3858e9 } rule (specificity 0,2,0) was beating .pledges-standing-action { color: #fff } and .pledges-empty-reset { color: #fff } (both at 0,1,0).
Bump both buttons' specificity to .entry-content .pledges-standing-action and .entry-content .pledges-empty-reset so the white-on-charcoal pill survives the theme's typography reset. Same prefix pattern already used to win the typography fight on the .pledges-standing-eyebrow label in #646.
### 2. Mobile filtered-out card: title wrapping to four lines
On mobile (verified live at 375px), the filtered-out standing card was packing avatar + body + Clear-filters action onto a single row with flex-wrap. The Clear filters button held its width on the right while the body shrank to about 10 characters wide, fragmenting "You're hidden by current filters." into four lines and compressing the explanatory sub-line into a column of two-word stubs.
Switch the mobile layout to flex-direction: column with align-items: flex-start, and stretch the action button full-width. The title gets full row to breathe, the sub-line wraps naturally, and the CTA lands in the thumb zone instead of competing for horizontal space.
Same fix automatically applies to the sign-in twin (logged-out state) which shares the same flex pattern with its own Sign-in action button.
## Test plan
- [ ] On a team where you're sponsored (e.g.
make.wordpress.org/meta/pledges/) at mobile width (375): verify the "You're hidden by current filters" card title is on one line, the sub-line reads naturally, and the Clear filters button spans full width below. - [ ] Same page on desktop: layout unchanged (avatar + body + button still on one row, action right-aligned).
- [ ] Logged-out on any team subsite at mobile width: verify the sign-in card layout — title not fragmenting, "Sign in →" button full-width.
- [ ] Filtered-out standing card's Clear filters button: text is white, not dark-blue.
- [ ] Empty-state card's Clear filters button (e.g.
/meta/pledges/?sponsorship=independentfor a sponsored user): text is white, not dark-blue.
## Files
wordpress.org/public_html/wp-content/themes/pub/wporg-breathe-2024/css/page-pledges.cssonly — CSS-only change, no PHP/JS touched.
This ticket was mentioned in PR #700 on WordPress/wordpress.org by @richtabor.
7 weeks ago
#5
## Summary
Updates the legacy WordPress.org site headers to use the WordPress blueberry color token instead of the older blue hex value.
The Sass now declares the header background with the CSS custom property and a matching fallback:
background: #3858e9; background: var(--wp--preset--color--blueberry-1, #3858e9);
This lets environments with the blueberry-1 preset use the shared WordPress color value, while older or non-tokenized contexts still render the same color through the fallback hex value.
This applies to:
- the base
wporgsite header - the
wporg-mainhome page header
The generated style.css and style-rtl.css files are included for both themes so the committed assets match the Sass source.
## Screenshots
## Test plan
- [ ] Visit the WordPress.org home page and confirm the header uses the updated WordPress blueberry color.
- [ ] Confirm the compiled styles include
var(--wp--preset--color--blueberry-1, #3858e9)with the hex fallback.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)