Opened 6 years ago

Closed 6 years ago

#3882 closed defect (bug) (fixed)

Various changes for note feedback

Reported by: keesiemeijer's profile keesiemeijer Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch


I found some small bugs and improvements now that the edit feedback feature is implemented in the wporg-developer theme.

1 - There is a potential of quicktags beeing added to the wrong element. The feedback section has an ID of feedback-{$comment_id} and the textarea of the feedback editor has an ID of feedback-{$instance}. As both of these variables are numbers there is a potential of duplicate IDs. This only affects comments with a very low IDs.

2 - When editing a note (in the front end) the link back to the note (in the breadcrumb trail) allways shows note 0.

3 - Javascript improvements. Only search the DOM for comments once.

Attachments (1)

3882.patch (4.4 KB) - added by keesiemeijer 6 years ago.

Download all attachments as: .zip

Change History (4)

6 years ago

#1 @coffee2code
6 years ago

In 7760: Fix swapped arguments between sprintf() and __().

Props keesiemeijer.
See #3882.

#2 @coffee2code
6 years ago

In 7761: Change HTML ID for editor to avoid potential ID conflict.

Props keesiemeijer.
See #3882.

#3 @coffee2code
6 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 7762: Improve JS by only searching for comments once.

Props keesiemeijer.
Fixes #3882.

Note: See TracTickets for help on using tickets.