Opened 6 years ago
Closed 6 years ago
#3882 closed defect (bug) (fixed)
Various changes for note feedback
Reported by: | keesiemeijer | Owned by: | coffee2code |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-patch |
Cc: |
Description
I found some small bugs and improvements now that the edit feedback feature is implemented in the wporg-developer theme.
1 - There is a potential of quicktags beeing added to the wrong element. The feedback section has an ID of feedback-{$comment_id}
and the textarea of the feedback editor has an ID of feedback-{$instance}
. As both of these variables are numbers there is a potential of duplicate IDs. This only affects comments with a very low IDs.
2 - When editing a note (in the front end) the link back to the note (in the breadcrumb trail) allways shows note 0
.
3 - Javascript improvements. Only search the DOM for comments once.
Attachments (1)
Change History (4)
Note: See
TracTickets for help on using
tickets.
In 7760: