WordPress.org

Making WordPress.org

Opened 3 months ago

Last modified 3 months ago

#3912 new enhancement

Make inserting links in user notes more user friendly

Reported by: keesiemeijer Owned by:
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch has-screenshots
Cc:

Description

To make inserting links in user notes more user friendly the link Quicktag button should be added to the note editors.

The following patch adds the link button. The search panel and checkbox to open links in a new tab in the modal window are hidden with CSS. I've also disabled the search query even though the search panel is hidden.

Attachments (6)

3912.patch (3.1 KB) - added by keesiemeijer 3 months ago.
Add link button
without-search-panel.png (25.2 KB) - added by keesiemeijer 3 months ago.
Without the search panel
normal-search-order.png (63.4 KB) - added by keesiemeijer 3 months ago.
Normal search results
search-orderby.png (54.9 KB) - added by keesiemeijer 3 months ago.
Search results ordered by (query) filters
3912.2.patch (3.0 KB) - added by keesiemeijer 3 months ago.
Link modal with search panel (without search filters)
3912.3.patch (4.0 KB) - added by keesiemeijer 3 months ago.
Link modal with search panel (with search filters applied)

Download all attachments as: .zip

Change History (9)

@keesiemeijer
3 months ago

Add link button

#1 follow-up: @DrewAPicture
3 months ago

Hmm, interesting that we'd hide the search panel (is it already hidden, we're just disabling the query?). We regularly remove third-party links from contributor notes to prevent linking outside resources that haven't been vetted.

I would think the search panel would be useful considering maybe the only relevant links I can think of in a note would be for linking to other elements in the Code Reference.

#2 in reply to: ↑ 1 @keesiemeijer
3 months ago

  • Keywords has-screenshots added

Replying to DrewAPicture:

No, I've hidden it with CSS and for good measure disabled the query as well. The query is expensive and the order of the results is different than the normal search results. It felt cluttered. But as you say, it could still be useful.

To have the same results (order) as a normal search we could set suppress_filters to false, but that would make the query even more expensive.

I've also just noticed we should restrict the post type to reference or handbook posts.

I will follow up with some screenshots of the differences.

@keesiemeijer
3 months ago

Without the search panel

@keesiemeijer
3 months ago

Normal search results

@keesiemeijer
3 months ago

Search results ordered by (query) filters

@keesiemeijer
3 months ago

Link modal with search panel (without search filters)

@keesiemeijer
3 months ago

Link modal with search panel (with search filters applied)

#3 @DrewAPicture
3 months ago

Yeah, let's skip the query and hide the modal for now. It would be nice to have smart linking in some form in the future but for now, making links easier to add would be a good addition.

Note: See TracTickets for help on using tickets.