Make inserting links in user notes more user friendly

[keesiemeijer]

To make inserting links in user notes more user friendly the link Quicktag button should be added to the note editors.

The following patch adds the link button. The search panel and checkbox to open links in a new tab in the modal window are hidden with CSS. I've also disabled the search query even though the search panel is hidden.

[keesiemeijer]

Add link button

[DrewAPicture]

Hmm, interesting that we'd hide the search panel (is it already hidden, we're just disabling the query?). We regularly remove third-party links from contributor notes to prevent linking outside resources that haven't been vetted.

I would think the search panel would be useful considering maybe the only relevant links I can think of in a note would be for linking to other elements in the Code Reference.

[keesiemeijer]

Replying to DrewAPicture:

No, I've hidden it with CSS and for good measure disabled the query as well. The query is expensive and the order of the results is different than the normal search results. It felt cluttered. But as you say, it could still be useful.

To have the same results (order) as a normal search we could set suppress_filters to false, but that would make the query even more expensive.

I've also just noticed we should restrict the post type to reference or handbook posts.

I will follow up with some screenshots of the differences.

[keesiemeijer]

Without the search panel

[keesiemeijer]

Normal search results

[keesiemeijer]

Search results ordered by (query) filters

[keesiemeijer]

Link modal with search panel (without search filters)

[keesiemeijer]

Link modal with search panel (with search filters applied)

[DrewAPicture]

Yeah, let's skip the query and hide the modal for now. It would be nice to have smart linking in some form in the future but for now, making links easier to add would be a good addition.

[coffee2code]

In 9716:

Developer: Enable link button for user contributed notes input form.

Props keesiemeijer, DrewAPicture.
Fixes #3912.

[coffee2code]

Thanks @keesiemeijer!

As Drew recommended, I went with the original patch​ implementing only the basic link form in the modal.

We can revisit including the search panel and search filters in a separate ticket if we want to pursue it later.