Making WordPress.org

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#3959 closed defect (bug) (fixed)

Footer hidden during theme preview

Reported by: seosbg's profile seosbg Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Theme Directory Keywords: has-patch
Cc:

Description

Hello I found a bug in wordpress.org. When you go to preview theme the footer is hidden. Please see the preview.

https://wordpress.slack.com/archives/C02QB8GMM/p1529701591000040

https://wordpress.slack.com/archives/C02QB8GMM/p1529701845000290

Thanks

Attachments (1)

meta-3959.diff (559 bytes) - added by pratikkry 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @tobifjellner
6 years ago

  • Component changed from General to Theme Directory
  • Keywords reporter-feedback added
  • Summary changed from Footer Issue to Footer hidden during theme preview

Could you add a bit more specific information here. Steps to reproduce (Preview directly on wordpress.org or in the admin pages of your own site, for instacne), perhaps with a screenshot where you point out what is wrong?

#2 @seosbg
6 years ago

Thanks @tobifjellner,

Select any theme and see the footer. Please see the image below.
https://seosthemes.com/wp-content/uploads/2018/11/footer.jpg

Best Regards

#3 @tobifjellner
6 years ago

  • Keywords reporter-feedback removed

So, trying to clarify here:
Visit the page of any theme directly in https://wordpress.org/themes and hit the preview button.
The bottom of the assigned space for the preview is outside of the parent window. Most easily this is seen by the fact that the end of the vertical scroll bar isn't visible.

By the way, here in trac you can upload images. But now I see what your trying to show.

#4 @Otto42
6 years ago

Changing

#customize-container iframe, .theme-install-overlay iframe {
    height: 100%;

to

#customize-container iframe, .theme-install-overlay iframe {
    height: calc( 100% - 32px );

Should reduce the size of the iframe to allow the footer to be shown in the container while leaving space at the top for the admin bar.

@pratikkry
6 years ago

#5 @pratikkry
6 years ago

  • Keywords has-patch added

#6 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from assigned to closed

In 8871:

Theme: Preview: Show the bottom 32px of the theme.

Props pratikkry, Otto42.
Fixes #3959.

#7 @dd32
5 years ago

In 8872:

Theme Directory: Bump cache after [8871].

See #3959.

Note: See TracTickets for help on using tickets.