Making WordPress.org

Opened 19 months ago

Closed 17 months ago

Last modified 17 months ago

#3985 closed defect (fixed)

Out of bounds pagination requests to the plugin directory return a 'raw' 404

Reported by: jonoaldersonwp Owned by: dd32
Milestone: Priority: low
Component: Plugin Directory Keywords: seo


E.g., https://wordpress.org/plugins/browse/popular/page/999/ returns a raw NGINX 404 page.

These should return standard WP 404 behaviour.

Change History (9)

#1 @SergeyBiryukov
19 months ago

  • Keywords reporter-feedback added

This was initially reported and fixed in #496.

The nginx rule is set up on load balancers to avoid excess load caused by the high pages.

The list of pages on https://wordpress.org/plugins/browse/popular/ is now limited to 99, any page beyond that should not be linked to from anywhere. I guess that resolves the issue?

#2 follow-up: @jonoaldersonwp
19 months ago

Nope, still need https://wordpress.org/plugins/browse/popular/page/100/ etc to return a 'nice' 404.

#3 in reply to: ↑ 2 @dd32
19 months ago

  • Keywords reporter-feedback removed

Replying to jonoaldersonwp:

Nope, still need https://wordpress.org/plugins/browse/popular/page/100/ etc to return a 'nice' 404.

That won't be possible, as it's blocked at the load balancer. As these pages are not linked to (if they are, let us know), and are only accessible via manual link creation I don't see any need to push for a change there. We could instead have the blocked pages redirect to /plugins/ maybe, but it really doesn't seem worth it.

I'm willing to close this as good-enough.

#4 @jonoaldersonwp
19 months ago

I'm not keen on writing this off. Anybody can link to those pages, and external systems (Google, Facebook etc), can, and will, freely request them.

Frankly, that any URL at all on the domain(s) can return a 'raw' error page is far from 'good-enough', and we should address that as a serious SEO/UX/analytics issue. Error states should never redirect, either, for reference.

If we're serving that error via the load balancer, at the very least, we could at the very least serve a cleaner/nicer static HTML page which contained useful content and resource links, appropriate meta (and HTTP header) content, and our Google Tag Manager code.

That said, if we're already routing these requests via the load-balancer, why can't we route them to a native WP 404 state (i.e., rewrite the request invisibly to wordpress.org/error)?


This ticket was mentioned in Slack in #meta by jonoaldersonwp. View the logs.

18 months ago

#6 @dd32
18 months ago

  • Keywords pending-systems added
  • Owner set to dd32
  • Status changed from new to accepted

#7 @jonoaldersonwp
18 months ago

  • Keywords seo added

#8 @jonoaldersonwp
17 months ago

  • Resolution set to invalid
  • Status changed from accepted to closed

Sorted, woo!

#9 @dd32
17 months ago

  • Keywords pending-systems removed
  • Resolution changed from invalid to fixed
Note: See TracTickets for help on using tickets.