WordPress.org

Making WordPress.org

Opened 23 months ago

Closed 5 weeks ago

#4011 closed defect (reported-upstream)

Correct Twitter URL and hashtag in email to global sponsors

Reported by: RMarks Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords:
Cc:

Description

Reported in Slack: https://wordpress.slack.com/archives/C08M59V3P/p1545183587066200

The email that goes out to global sponsors to alert them of an upcoming camp has some problems with the way the information regarding the camps' Twitter accounts is displayed. Here's an example from the recent WordCamp Proldiv email: Their Twitter handle is https://twitter.com/https://twitter.com/WordCampPlovdiv and their hashtag is https://twitter.com/hashtag/#WCPLD Can we get the repetitive "https://twitter.com/" removed and the hashtag limited to just the hashtag in this case it would be #WCPLD

Attachments (2)

local-twitter-values.png (40.4 KB) - added by RMarks 23 months ago.
Screen Shot 2018-12-19 at 6.45.46 PM.png (15.2 KB) - added by iandunn 23 months ago.
production

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


23 months ago

#2 @RMarks
23 months ago

I'd like to make this change, but don't see this code in the meta repository. Can someone point me to where this code is located?

Version 0, edited 23 months ago by RMarks (next)

#4 @RMarks
23 months ago

I've uploaded a screenshot of what I see in my local development environment. Could someone please send me the same for Plovdiv from the production enviroment? I believe the additional https://twitter.com/ parts are being stored along with the Twitter username.

For the hashtag, I believe the # was being added in the UI. https://twitter.com/hashtag/WCPLD is a valid URL.

In both of these cases, I think removing the URL and # when saving a WordCamp would be the better direction to go. Thoughts?

Last edited 23 months ago by RMarks (previous) (diff)

#5 @iandunn
23 months ago

🤔

My instinct is to normalize them to be full/valid URLs and hashtags -- e.g., https://twitter.com/WordCampPlovdiv and #WCPLD -- since that feels like it's more intuitive/expected/"correct".

I don't hold that opinion very strongly, though; I can see the other side of it as well.

I'd be curious to see how those fields are being used across the codebase. That may be a factor in how practical one option would be over the other.

#6 @RMarks
23 months ago

I agree that they should be normalized. The mailer.php code mentioned in comment:3 is attempting to make both into URLs:
https://twitter.com/WordCampPlovdiv
https://twitter.com/hashtag/WCPLD

It may be useful to look at the production database and see what the previous usage has been.
For the handle: Username alone, Username with the @ symbol, or URL to profile
For the hashtag: Hashtag letters with or without the # symbol

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.


5 months ago

#9 @dd32
5 weeks ago

  • Resolution set to reported-upstream
  • Status changed from new to closed

This ticket has been moved to GitHub https://github.com/WordPress/wordcamp.org/issues/609

Note: See TracTickets for help on using tickets.