WordPress.org

Making WordPress.org

#4013 closed defect (fixed)

Add oEmbed functionality to handbooks

Reported by: dd32 Owned by: dd32
Milestone: Priority: normal
Component: Handbooks Keywords:
Cc:

Description

As reported in https://github.com/WordPress/gutenberg/issues/13001 oEmbed for handbook content doesn't work as expected.

I'm unsure why it's not being handled correctly, I suspect it's a query reset or something somewhere..

If it was working, this url would look similar to this one which is a generic empty oEmbed.

Change History (7)

#1 @dd32
10 months ago

The Example URL https://developer.wordpress.org/themes/functionality/sidebars/ is the one that didn't work.

Oddly enough the Gutenberg Handbook does though which might mean it's in the Dev theme and not the handbooks code?

#2 @dd32
10 months ago

In 7991:

Gutenberg Docs: Don't add the Github edit link on oEmbed views.

This fixes having 2 super-large octocats appear in the oEmbed preview when embedding links to the Gutenberg Handbook in WordPress pages.

H/t DrewAPicture.
See https://github.com/WordPress/gutenberg/issues/13001.
See #4013.

This ticket was mentioned in Slack in #docs by chrisvanpatten. View the logs.


10 months ago

#4 follow-up: @drywallbmb
10 months ago

Is this also causing the formatting issues on https://developer.wordpress.org/plugins/the-basics/header-requirements/ ? I know this page was recently edited and was not exhibiting these formatting issues previously.

See https://cshp.co/2EDtL6x for screenshot example.

#5 in reply to: ↑ 4 ; follow-up: @DrewAPicture
10 months ago

Replying to drywallbmb:

Is this also causing the formatting issues on https://developer.wordpress.org/plugins/the-basics/header-requirements/ ? I know this page was recently edited and was not exhibiting these formatting issues previously.

See https://cshp.co/2EDtL6x for screenshot example.

The formatting issues are a separate problem. I've fixed the article you linked by converting it to blocks and then converting the previously shortcode-wrapped code to instead live in a Syntax Highlighted Code block.

#6 in reply to: ↑ 5 @drywallbmb
10 months ago

Replying to DrewAPicture:

Replying to drywallbmb:

Is this also causing the formatting issues on https://developer.wordpress.org/plugins/the-basics/header-requirements/ ? I know this page was recently edited and was not exhibiting these formatting issues previously.

See https://cshp.co/2EDtL6x for screenshot example.

The formatting issues are a separate problem. I've fixed the article you linked by converting it to blocks and then converting the previously shortcode-wrapped code to instead live in a Syntax Highlighted Code block.

Awesome, thanks! Looks much better now.

#7 @dd32
10 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 7994:

Handbooks: Don't override the embed.php template, and don't prefix the TOC to the embed previews.

Fixes #4013.

Note: See TracTickets for help on using tickets.