Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#4039 closed enhancement (fixed)

Prevent theme copies from being uploaded

Reported by: poena's profile poena Owned by: dd32's profile dd32
Milestone: Priority: high
Component: Theme Review Keywords: has-patch 2nd-opinion


Copies of themes that are already in the theme directory gets uploaded by mistake by users who does not know what the theme upload form is for.

We have tried to change the text on the upload page to prevent this, but it is not helping.

Suggested solution:
Even when uploaders change the name of the theme, they usually leave the Theme URI unchanged.

We can compare the Theme URI with existing themes, and stop the upload if the theme URI is a duplicate.
We can also include an exception where the upload can be allowed if the theme author is the same as the uploader.

Attachments (1)

4039.diff (4.6 KB) - added by dd32 5 years ago.

Download all attachments as: .zip

Change History (14)

5 years ago

#1 @dd32
5 years ago

  • Keywords has-patch 2nd-opinion added

4039.diff is an implementation of this, however..

Blocking this doesn't actually fix the problem, the uploader has most likely already changed the Theme Name (as they were blocked on uploading, and directed them to change it) and is now attempting to upload with a changed Name, but not URI.

All this change will do, is prompt them to change the Theme URI too, and then upload into the review queues with even less data available to say "This is a duplicate".

I'm not against implementing this, but as part of it, I think we need to reconsider the text displayed when it fails the Theme Name in use by another author too.

Ideally, failing either that check, or this check, would display an even firmer "Are you sure you're in the right place?" notice, but I'm not sure on the wording right now.

This ticket was mentioned in Slack in #themereview by dd32. View the logs.

5 years ago

#3 @dd32
5 years ago

For reference, the only text displayed on the actual upload screen in the event of a duplicative theme name upload is this:

There is already a theme called Twenty Ten by a different author. Please change the name of your theme in style.css and upload it again.

This ticket was mentioned in Slack in #themereview by acosmin. View the logs.

5 years ago

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.

5 years ago

#6 @joyously
5 years ago

How about if the text is more explicit: "Duplicates of themes are not allowed in the repository. Are you sure you are in the right place?"

#7 @tellyworth
5 years ago

Yeah let's try this with text similar to @joyously 's suggestion. Ideally with some kind of stats or logging, so we know how often it happens.

If it still happens often, one option might be a time-out for users who upload a dupe. If they don't already have a published theme, disable the upload form for that user for a few hours.

#8 @poena
5 years ago

Yes I agree, or "give up" and move the link somewhere else, maybe to the bottom of the page?

This ticket was mentioned in Slack in #themereview by poena. View the logs.

5 years ago

This ticket was mentioned in Slack in #themereview by dingo_d. View the logs.

5 years ago

#11 @dingo_d
5 years ago

  • Priority changed from normal to high

Can we implement the patch @dd32 suggested but with text that @joyously suggested?

As for the statistics I think this queue gives a good overview of duplicates:

#12 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 10431:

Theme Directory: Block duplicate Theme URI's (except when by the current author) and add a "Are you sure you want to upload this here" type message for those who are lost.

Fixes #4039.

#13 @dd32
4 years ago

In 10432:

Theme Directory: Only use URL rather than URI in the user-facing text.

See r10431.
See #4039.

Note: See TracTickets for help on using tickets.