WordPress.org
Get WordPress

Making WordPress.org

Opened 6 years ago

Closed 5 years ago

#4046 closed defect (bug) (fixed)

WordCamp.org: meetups do have singular view

Reported by: sippis's profile sippis Owned by: sippis's profile sippis
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: has-patch needs-testing
Cc:

Description

All WordPress meetups do have singular page visible on central.wordcamp.org. Those pages do not have any valid or useful information, so those should not be exposed to the public. This is regardless of meetup status.

For example, take a look at ​https://central.wordcamp.org/wp_meetup/palakkad-kerala-india/

Attachments (1)

4046.diff​ (1.0 KB) - added by sippis 5 years ago.

Download all attachments as: .zip

Change History (8)

#1 @sippis
6 years ago

This might partially fix itself after applying the patch in #3740, but still expose "public" meetups.

This ticket was mentioned in ​Slack in #meta-wordcamp by sippis. ​View the logs.
6 years ago

@sippis
5 years ago

#3 @sippis
5 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

This patch:

  • sets public to false on wp_meetup cpt
  • sets has_archive to false on wp_meetup cpt
  • removes query_var on wp_meetup cpt as it is un-neccessary since 'public'=>false overrides it

This ticket was mentioned in ​Slack in #meta-wordcamp by iandunn. ​View the logs.
5 years ago

#5 @iandunn
5 years ago

Based on the latest Slack discussion, this is ready for testing/commit.

This ticket was mentioned in ​Slack in #meta-wordcamp by coreymckrill. ​View the logs.
5 years ago

#7 @coreymckrill
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with ​https://github.com/WordPress/wordcamp.org/commit/fa145d28abc613fe6f4eacc9190d016b22feee71

Note: See TracTickets for help on using tickets.