WordPress.org

Making WordPress.org

Opened 6 months ago

Last modified 5 months ago

#4079 assigned enhancement

Remote CSS - Allow github.io domain

Reported by: jmslbam Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch
Cc:

Description

For WordCamp Rotterdam 2019 I wanted to let the Jekyll installation of GitHub pages generate the final CSS file. This way the whole team could just adjust a .scss file via GitHub.com and then refresh the remote CSS.

Using Jekyll is easier for the team because this prevents the need of installing NPM etc to compile the files to a CSS file and then commit it.

Within the function whitelist_trusted_hostnames add github.io.
https://meta.trac.wordpress.org/browser/sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-remote-css/platforms/github.php#L25

Change History (2)

#1 @iandunn
6 months ago

  • Component changed from General to WordCamp Site & Plugins

#2 @iandunn
5 months ago

  • Keywords needs-patch added
  • Status changed from new to assigned

This sounds like a good idea, but it's a bit more complicated than just adding github.io to the safelist array. We'll also need to adjust things so that subdomains of safelist entries are allowed.

Note: See TracTickets for help on using tickets.