WordPress.org
Get WordPress

Making WordPress.org

Opened 6 years ago

Closed 4 years ago

#4079 closed enhancement (maybelater)

Remote CSS - Allow github.io domain

Reported by: jmslbam's profile jmslbam Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch
Cc:

Description

For WordCamp Rotterdam 2019 I wanted to let the Jekyll installation of GitHub pages generate the final CSS file. This way the whole team could just adjust a .scss file via GitHub.com and then refresh the remote CSS.

Using Jekyll is easier for the team because this prevents the need of installing NPM etc to compile the files to a CSS file and then commit it.

Within the function whitelist_trusted_hostnames add github.io.
https://meta.trac.wordpress.org/browser/sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-remote-css/platforms/github.php#L25

Change History (4)

#1 @iandunn
6 years ago

  • Component changed from General to WordCamp Site & Plugins

#2 @iandunn
6 years ago

  • Keywords needs-patch added
  • Status changed from new to assigned

This sounds like a good idea, but it's a bit more complicated than just adding github.io to the safelist array. We'll also need to adjust things so that subdomains of safelist entries are allowed.

This ticket was mentioned in ​Slack in #meta-wordcamp by ryelle. ​View the logs.
4 years ago

#4 @ryelle
4 years ago

  • Resolution set to maybelater
  • Status changed from assigned to closed

​Discussed in slack this week — we're not sure how many people would use this feature, so this will be closed for now.

Note: See TracTickets for help on using tickets.