Making WordPress.org

Opened 6 years ago

Closed 4 years ago

#4093 closed enhancement (fixed)

Check for `user_nicename` when meetup organisers are added

Reported by: hlashbrooke's profile hlashbrooke Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch good-first-bug
Cc:

Description

When we add the usernames of meetup group organisers in the meetup tracker (https://central.wordcamp.org/wp-admin/edit.php?post_type=wp_meetup), the system checks if it is a valid username by checking against the user_login field. This is fine in most cases, but in some instances the username supplied is actually the user_nicename as it is copied from the profile URL.

When that happens, the only solution is to ask in the #meta channel on Slack if someone can help with providing the username from the given nicename. That is obviously not ideal.

The simplest solution here would be to add a secondary check to match the provided username against the user_nicename field if the initial check against the user_login field fails. This check is only run at the time that the meetup listing is saved, so any processing overhead created by an additional check wouldn't be a problem.

Change History (6)

This ticket was mentioned in Slack in #community-events by bph. View the logs.


6 years ago

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


6 years ago

#3 @iandunn
6 years ago

  • Keywords good-first-bug added
  • Status changed from new to assigned

+1, see slack conversation linked above for notes

#4 @dd32
5 years ago

In 9373:

Trac: Github PRs: Add some initial code to sync a PR Comment (Not a code review comment..) over to Trac for visibility.

This isn't yet active, as Github isn't sending the issue_comment action yet.

See #4093.

This ticket was mentioned in Slack in #meta-wordcamp by ryelle. View the logs.


4 years ago

#6 @ryelle
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.