WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 4 years ago

#410 closed defect (fixed)

BuddyPress/bbPress Trac attachment links displayed as blocks

Reported by: boonebgorges Owned by: johnjamesjacoby
Milestone: Priority: lowest
Component: buddypress.org Keywords:
Cc:

Description

In themes/bb-base/style.css (link 739) we see this declaration:

.attachment {
  display: block;
}

This is causing Trac attachment links, which get the attachment class, to be displayed as block elements, rather than inline. See https://buddypress.trac.wordpress.org/ticket/5429#comment:11 for an example.

I guess the ideal solution is to make the .attachment declaration more specific, but I'm uncertain what it's meant to apply to, so I don't have a concrete suggestion for how to do so. Alternatively, the following would work fine:

a.attachment {
  display: inline;
}

Attachments (1)

410.2.diff (605 bytes) - added by netweb 4 years ago.

Download all attachments as: .zip

Change History (5)

#1 @johnjamesjacoby
5 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 980:

BuddyPress.org: Remove .attachment styling from bb-base theme. We can customize what non-image attachments look like when the time comes. Fixes #410.

#2 @boonebgorges
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This crept back in in [1259], for what appears to be reasons unrelated to Trac. May I suggest, as a low-impact fix:

.attachment {
    display: block;
}

body.trac .attachment {
    display: inline;
}

@netweb
4 years ago

#3 @netweb
4 years ago

Replying to boonebgorges:

May I suggest, as a low-impact fix:

Works for me, added in 410.2.diff

Note: Will need to bump the CSS version when committing in:
/sites/trunk/buddypress.org/public_html/wp-content/themes/bb-base/functions.php

#4 @netweb
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 2015:

BuddyPress.org: Add .attachment styling for bbPress and BuddyPress Trac in bb-base theme.

Fixes #410. Props boonebgorges.

Note: See TracTickets for help on using tickets.