Opened 12 years ago
Closed 10 years ago
#410 closed defect (bug) (fixed)
BuddyPress/bbPress Trac attachment links displayed as blocks
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | lowest | |
| Component: | buddypress.org | Keywords: | |
| Cc: |
Description
In themes/bb-base/style.css (link 739) we see this declaration:
.attachment {
display: block;
}
This is causing Trac attachment links, which get the attachment class, to be displayed as block elements, rather than inline. See https://buddypress.trac.wordpress.org/ticket/5429#comment:11 for an example.
I guess the ideal solution is to make the .attachment declaration more specific, but I'm uncertain what it's meant to apply to, so I don't have a concrete suggestion for how to do so. Alternatively, the following would work fine:
a.attachment {
display: inline;
}
Attachments (1)
Change History (5)
#1
@
11 years ago
- Owner set to johnjamesjacoby
- Resolution set to fixed
- Status changed from new to closed
#2
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
This crept back in in [1259], for what appears to be reasons unrelated to Trac. May I suggest, as a low-impact fix:
.attachment {
display: block;
}
body.trac .attachment {
display: inline;
}
#3
@
10 years ago
Replying to boonebgorges:
May I suggest, as a low-impact fix:
Works for me, added in 410.2.diff
Note: Will need to bump the CSS version when committing in:
/sites/trunk/buddypress.org/public_html/wp-content/themes/bb-base/functions.php
In 980: