Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#4164 closed defect (bug) (fixed)

Problem with displaying description of the theme in a proper languages.

Reported by: apollo13themes's profile apollo13themes Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: General Keywords:


Hello :-)

For my theme, named Rife Free I have 3 localization done at 100% with theme description included.

However, on each language description is still displayed in English:
Portuguese (Brazil)
Dutch (Belgium)
I also have the description accepted in Polish.

The French translation is week old and still displayed in English.

I have asked about it in #polyglots slack channel and they said:

During some period of time the synchronization must have been down and several languages/themes are affected.
A meta ticket is probably the best way to go

So here I am asking about help or instructions what should I do next.

With kind regards.

Change History (5)

#1 @dd32
5 years ago

This was the same as #1628, except that the Emoji's were being HTML decoded in addition to the other HTML entities, where they shouldn't have been in order to match.

It seems that wp_specialchars_decode is the needed function in this case, but I suspect that it doesn't cover all bases.

#2 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 8219:

GlotPress Translation Bridge: When we can't find a translation, use html_entity_decode() instead of html_entity_decode() as WordPerss only encodes certain characters.

Hopefully nothing was relying upon html_entity_decode() here, if it was, we'll have to attempt both.

Fixes #4164.

#3 @apollo13themes
5 years ago

Thanks for such quick fix and looking into this!

@dd32 - you may want to edit your comment as you have used twice html_entity_decode instead of wp_specialchars_decode

#4 @dd32
5 years ago

@apollo13themes Unfortunately that was in the SVN commit so can't be changed :(

The caches in question should've expired by now, so let me know if you don't see it working/etc.

#5 @apollo13themes
5 years ago

O sorry, I didn't notice it was from the commit.

Your fix works everywhere, on every language that we have a description for!

Thanks once again!

Note: See TracTickets for help on using tickets.