Opened 6 years ago
Closed 6 years ago
#4167 closed defect (bug) (fixed)
Huge pagination values break things
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | low | |
Component: | Support Forums | Keywords: | seo |
Cc: |
Description
E.g., take a look at the behaviour of https://wordpress.org/support/view/support-forum-yes/page/9999999999999999999999999999999999/.
This, and other extremely high values redirect to a maxint pagination value (e.g., https://wordpress.org/support/view/support-forum-yes/page/9223372036854775807/).
This, and other pagination states in the same order of magnitude (e.g., https://wordpress.org/support/view/support-forum-yes/page/9223372036854775802/) come with some headaches, where they return the 'page 1' state but with incorrect meta values.
Therefore...
All invalid range values should return 404 behaviour, as per low range invalid values do at present (e.g., https://wordpress.org/support/view/support-forum-yes/page/100/). Related, #4166.
9223372036854775807
isPHP_INT_MAX
on a 64bit system, so that's where the redirect is coming from (bbPress is probably usingabsint()
orintval()
)https://bbpress.trac.wordpress.org/ticket/3018#comment:1 is kinda related I think.
While this is also a bbPress problem, it's probably one we can workaround on dotorg without too much issues.