WordPress.org

Making WordPress.org

Opened 5 months ago

Closed 5 months ago

#4167 closed defect (fixed)

Huge pagination values break things

Reported by: jonoaldersonwp Owned by:
Milestone: Priority: low
Component: Support Forums Keywords: seo
Cc:

Description

E.g., take a look at the behaviour of https://wordpress.org/support/view/support-forum-yes/page/9999999999999999999999999999999999/.

This, and other extremely high values redirect to a maxint pagination value (e.g., https://wordpress.org/support/view/support-forum-yes/page/9223372036854775807/).

This, and other pagination states in the same order of magnitude (e.g., https://wordpress.org/support/view/support-forum-yes/page/9223372036854775802/) come with some headaches, where they return the 'page 1' state but with incorrect meta values.

Therefore...

All invalid range values should return 404 behaviour, as per low range invalid values do at present (e.g., https://wordpress.org/support/view/support-forum-yes/page/100/). Related, #4166.

Change History (5)

#1 @dd32
5 months ago

9223372036854775807 is PHP_INT_MAX on a 64bit system, so that's where the redirect is coming from (bbPress is probably using absint() or intval())

https://bbpress.trac.wordpress.org/ticket/3018#comment:1 is kinda related I think.

While this is also a bbPress problem, it's probably one we can workaround on dotorg without too much issues.

#2 @dd32
5 months ago

In 8224:

WordPress.org: Force a 404 for any logged out paged requests above MAX_PAGES, this is done to avoid bbPress overriding it later.

See #4167.

#3 @dd32
5 months ago

[8224] covers this for logged out users, is that enough for SEO purposes?

#4 @jonoaldersonwp
5 months ago

Yeah that's super, thanks!

#5 @dd32
5 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Cool :) I'm going to close this as fixed then, It's still janky for logged in users, but hopefully if Search engines never index pages like that, users will never end up on a page like that!

Note: See TracTickets for help on using tickets.