Opened 5 years ago

Closed 5 years ago

#4173 closed defect (bug) (fixed)

Gruntfile in wporg-plugins theme refers to script removed from wp-api package

Reported by: diddledani's profile diddledani Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch


The Gruntfile.js in the wporg-plugins theme has this block:

		shell: {
			build: {
				command: './node_modules/wpapi/lib/data/update-default-routes-json.js --endpoint= --output=./client'

The file it references, update-default-routes-json.js, is not in the distribution of wp-api on NPM since version 1.2.0. The definition in the package.json is to pull versions matching ^1.0.0 which means that 1.2.0 will be pulled in new or cleaned setups of the meta-environment. When the newer version is installed via npm, such as will occur for anyone setting up a new meta-environment system, the wporg-plugins theme build process will fail.

The removal/move of the script in wp-api was in this commit.

Attachments (2)

4173.patch (3.7 KB) - added by ck3lee 5 years ago.
4173.1.patch (3.9 KB) - added by ck3lee 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Plugin Directory

5 years ago

#2 @ck3lee
5 years ago

  • Keywords has-patch added

Thank you @diddledan for raising this. I had the same issue too. I've attached attachment:4173.patch hoping to fix this. Can you help test?

Version 0, edited 5 years ago by ck3lee (next)

5 years ago

#3 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 8708:

Plugin Directory: Fix grunt build for the JS client.

Props ck3lee.
Fixes #4173.

Note: See TracTickets for help on using tickets.