WordPress.org

Making WordPress.org

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#4227 closed defect (fixed)

footer Social Icon design Issue

Reported by: utsav72640 Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: General Keywords: has-screenshots has-patch dev-feedback
Cc:

Description

https://wordpress.org/download/

footer Socia Icon design issue.

Attachments (2)

downloadissue.png (47.1 KB) - added by utsav72640 5 months ago.
https://wordpress.org/download/
4227.diff (257.6 KB) - added by garrett-eclipse 5 months ago.
Isolated the .dashicons styles on the download page to the .site-content to avoid affecting the footer.

Download all attachments as: .zip

Change History (8)

#1 @utsav72640
5 months ago

Above issue will fixed if we add important from below css code.

.dashicons, .dashicons-before:before {
    display: inline-block !important;
    width: 20px !important;
    height: 20px !important;
    font-size: 20px !important;
    line-height: 1;
    font-family: dashicons;
    text-decoration: inherit;
    font-weight: 400;
    font-style: normal;
    vertical-align: top;
    text-align: center;
    transition: color .1s ease-in;
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;
}
Last edited 5 months ago by utsav72640 (previous) (diff)

@garrett-eclipse
5 months ago

Isolated the .dashicons styles on the download page to the .site-content to avoid affecting the footer.

#2 @garrett-eclipse
5 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed

Thanks @utsav72640 I see what you're saying there.

These icons were updated here - #3655

Seems the dashicons in the page content for the Download page has custom CSS which should probably just be isolated to the page content. I've uploaded 4227.diff to isolate the .dashicons styles on the Download page into the .site-content so it doesn't affect the footer.

Cheers

Last edited 5 months ago by SergeyBiryukov (previous) (diff)

#3 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#4 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 8362:

WordPress.org Main Theme: Download: Apply Dashicon styles to the main content only, to avoid interfering with the footer.

Props garrett-eclipse, utsav72640.
Fixes #4227.

#5 @SergeyBiryukov
5 months ago

In 8363:

WordPress.org Main Theme: Download: Bump CSS version for cache bust after [8362].

See #4227.

#6 @garrett-eclipse
5 months ago

Thanks @SergeyBiryukov srry I overlooked the .scss I'll need to learn the meta build from you

Note: See TracTickets for help on using tickets.