Making WordPress.org

Context Navigation

← Previous Ticket
Next Ticket →

Opened 7 years ago

Closed 2 years ago

#4233 closed enhancement (invalid)

Footer wordpress twitter id hover underline break

Reported by:	immeet94	Owned by:	dd32
Priority:	high	Milestone:
Component:	General	Keywords:	has-patch
Cc:

Description

https://wordpress.org/download/
footer wordpress icon hover design issue.When hover over @wordpress that time underline is breaking at @ point.

Attachments (7)

#4233 (128.6 KB ) - added by immeet94 7 years ago.
wordpress_issue.png (33.2 KB ) - added by immeet94 7 years ago.
#4233.2 (128.6 KB ) - added by immeet94 7 years ago.: Please see this file for patch
wordpress_sloved_hover_issue.png (27.6 KB ) - added by immeet94 7 years ago.: After applying changes issues solved.
#4233.3 (257.7 KB ) - added by immeet94 7 years ago.: File location : Index: wordpress.org/public_html/wp-content/themes/pub/wporg-main/css/style-rtl.css
#4233.2.diff (128.6 KB ) - added by dd32 7 years ago.: attaching as a .diff in the hope Trac can highlight changes.
#4233.diff (257.7 KB ) - added by immeet94 7 years ago.: upload patch file as a .diff

Download all attachments as: .zip

Change History (20)

@immeet94
7 years ago

Attachment #4233 added

@immeet94
7 years ago

Attachment wordpress_issue.png added

@immeet94
7 years ago

Attachment #4233.2 added

Please see this file for patch

@immeet94
7 years ago

Attachment wordpress_sloved_hover_issue.png added

After applying changes issues solved.

@immeet94
7 years ago

Attachment #4233.3 added

File location : Index: wordpress.org/public_html/wp-content/themes/pub/wporg-main/css/style-rtl.css

#1 @immeet94
7 years ago

Priority normal → high
Summary Footer wordpress icon underline break → Footer wordpress twitter id hover underline break

@dd32
7 years ago

Attachment #4233.2.diff added

attaching as a .diff in the hope Trac can highlight changes.

#2 @immeet94
7 years ago

Keywords has-patch added

#3 @dd32
7 years ago

Owner set to dd32
Status new → accepted

Thanks @immeet94 that looks like it'll work to me.

I'll apply the patch to the source SCSS files and get this fixed up shortly.

@immeet94
7 years ago

Attachment #4233.diff added

upload patch file as a .diff

#4 @dd32
7 years ago

Resolution → fixed
Status accepted → closed

In 8388:

WordPress.org base theme: Fix the underlining for the @ in the Twitter footer link.

Props immeet94.
Fixes #4233.

#5 @dd32
7 years ago

In 8389:

WordPress.org & WordPress.org Themes: Upgrade the SCSS & CSS minification routines to work. This matches the implementation used by other themes.

See #4233.

#6 @dd32
7 years ago

In 8390:

WordPress.org Main Theme: Minify CSS.

See #4233.

#7 @dd32
7 years ago

In 8391:

Learn: Minify CSS.

See #4233.

#8 @dd32
7 years ago

In 8392:

WordPress.org Main Theme, Learn, Plugins & Themes: Apply [8388] to properly underline footer links.

This includes some automatically-'corrected' SCSS files.

See #4233.

#9 @dd32
7 years ago

In 8393:

WordPress.org Main, Plugins, and Themes themes: Bump cache buster after [8392].

Fixes #4233.

#10 @dd32
7 years ago

Resolution fixed
Status closed → reopened

This should be reverted in favour of a fix specific to the Twitter link and any other @mentions.

#11 @dd32
7 years ago

As mentioned in #4246, the @user link on the Forum Profile needs this fix too.

#12 @dd32
7 years ago

#4246 was marked as a duplicate.

#13 @dd32
2 years ago

Resolution → invalid
Status reopened → closed

This ticket is no longer relevant, as the design changed.

Note: See TracTickets for help on using tickets.

Download in other formats: