WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#4235 closed defect (fixed)

Trac Error

Reported by: arena Owned by:
Milestone: Priority: normal
Component: Codex Keywords:
Cc:

Description

Change History (5)

#1 @garrett-eclipse
9 months ago

  • Keywords close added

Thanks @arena this is due to the new build process in 5.0 which moved files into a js folder and then during the build process they'd be introduced into their final location.
I've updated - https://codex.wordpress.org/Javascript_Reference/wp.template#Location

With the following verbiage;
This is defined in js/_enqueues/wp/util.js
And output in wp-includes/js/wp-util.js during build.

This fixes the broken link and explains that even though the link is somewhere else it is output in it's original location after build. I'm sure there's more instances of this now so will take a look when I can.

Cheers
*I can't seem to resolve as fixed so am leaving with the 'close' tag.

#2 @dd32
9 months ago

  • Keywords close removed
  • Resolution set to fixed
  • Status changed from new to closed

Marking as fixed.

Might be worth keeping this in mind for some files and updating the Trac template to account for it somehow.

#3 follow-up: @garrett-eclipse
9 months ago

Thanks @dd32

Can you point out the Trac template and I can take a look. Also is it possible to do a mass-search on the Codex to find any links containing '/wp-includes/js'?

I've gone through manually in the Javascript_Reference to correct the following pages;
https://codex.wordpress.org/Javascript_Reference/wp.template#Location
https://codex.wordpress.org/Javascript_Reference/wp#Structure
https://codex.wordpress.org/Javascript_Reference/wp.media#Location
https://codex.wordpress.org/Javascript_Reference/wp.template#Location
https://codex.wordpress.org/Javascript_Reference#Locations

If there's an easy way to identify others let me know and I'd be happy to correct them.

Cheers

#4 in reply to: ↑ 3 @dd32
9 months ago

I don't actually know all-that-much about Codex.. soo this is my understanding..

Replying to garrett-eclipse:

Can you point out the Trac template

That's handled by the <includeonly> section at the top of https://codex.wordpress.org/index.php?title=Template:Trac&action=edit
Changing that doesn't look like it's needed, given how few references there are to it now (and future replacement with Devhub/etc)

Also is it possible to do a mass-search on the Codex to find any links containing '/wp-includes/js'?

It looks like this internal-trac search will do the job:
hxxxs://codex.wordpress.org/index.php?title=Special%3ASearch&profile=default&fulltext=Search&search=%22%7B%7BTrac%7C%2Fwp-includes%2Fjs%22
(Replace hxxxs with https://, I don't want Google indexing that..)

Note: See TracTickets for help on using tickets.