WordPress.org

Making WordPress.org

Opened 5 months ago

Closed 3 months ago

Last modified 3 months ago

#4250 closed defect (fixed)

Underline links in locale banners

Reported by: SergeyBiryukov Owned by: ck3lee
Milestone: Priority: normal
Component: General Keywords: needs-patch
Cc:

Description

Background: #2696, #3184.

Per accessibility best practices, standalone links without underline are fine (in menus, etc.), however links that are a part of other text should be underlined and not rely on color alone to be distinguished.

This applies to existing locale banners ("WordPress is also available in ..." on WP.org home page; "This plugin is not translated into ... yet" in the plugin directory) and any future locale banners: #1864, #1952.

Discussed with @Travel_girl and @rianrietveld at WordCamp Nordic 2019.

Attachments (1)

4250.diff (606 bytes) - added by ck3lee 3 months ago.

Download all attachments as: .zip

Change History (15)

#1 @Travel_girl
5 months ago

  • Keywords needs-patch added

#2 @SergeyBiryukov
5 months ago

In 8437:

Support Theme: Underline links in notices.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

See #4250.

#3 @SergeyBiryukov
5 months ago

In 8438:

Support Theme: Bump CSS version for cache bust after [8437].

See #4250.

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


4 months ago

#5 @tellyworth
4 months ago

  • Owner set to ck3lee
  • Status changed from new to assigned

@ck3lee
3 months ago

#6 @ck3lee
3 months ago

Also added attachment:4250.diff to underline links for plugin banners.

#7 @tellyworth
3 months ago

In 8759:

Plugin dir theme: underline links in locale banner.

Props ck3lee.
See #4250

#8 @tellyworth
3 months ago

In 8760:

Plugin dir theme: cache bust for [8759]

See #4250

#9 follow-up: @tellyworth
3 months ago

Does that patch fix the last of it or is there more to do here?

#10 in reply to: ↑ 9 @SergeyBiryukov
3 months ago

Replying to tellyworth:

Does that patch fix the last of it or is there more to do here?

Per the ticket description, the same should be done for the locale banner on WP.org home page.

#11 @SergeyBiryukov
3 months ago

In 8769:

Plugin Directory Theme: Remove unnecessary a:hover override for locale banner.

The color is not used for any other links on the page.

See #4250.

#12 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 8770:

WordPress.org Main Theme: Underline links in locale banner.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Fixes #4250.

#13 @SergeyBiryukov
3 months ago

In 8771:

WordPress.org Main Theme: Bump CSS version for cache bust after [8770].

See #4250.

#14 @SergeyBiryukov
3 months ago

In 8772:

Plugin Directory Theme: Bump CSS version for cache bust after [8769].

See #4250.

Note: See TracTickets for help on using tickets.