Pagination components shouldn't link to 'page 1' state

[jonoaldersonwp]

On templates like ​https://wordpress.org/support/view/support-forum-no/page/2/, the link to the first page in the pagination component links to /page/1/. This should instead link to the series root.

[dd32]

Ultimately caused by WordPress's paginate_links() function returning /page/1/ links, and bbPress doing a very bland attempt at working around this in ​https://bbpress.trac.wordpress.org/browser/branches/2.5/includes/topics/template.php?marks=409#L405 by only replacing /page/1/' with '.. but core uses " for some links.

This is fixed in bbPress 2.6 with bbp_paginate_links() I believe, which we should probably look at moving to instead.

[johnjamesjacoby]

As @dd32 mentioned, this is indeed fixed upstream already in bbPress 2.6. 👍

[Clorith]

This has indeed been resolved at this time.

[SergeyBiryukov]

Related: #4840