WordPress.org
Get WordPress

Making WordPress.org

Opened 7 years ago

Closed 7 years ago

#4415 closed defect (bug) (fixed)

Invalid theme browse categories/types should 404

Reported by: jonoaldersonwp Owned by: dd32
Priority: normal Milestone:
Component: Theme Directory Keywords: seo analytics
Cc:

Description

E.g., ​https://wordpress.org/themes/browse/sausages/

Change History (9)

#1 @dd32
7 years ago

  • Owner set to dd32
  • Resolution → fixed
  • Status new → closed

In 9188:

Theme Directory: 404 on invalid browse requests.

Fixes #4415.

#2 @dd32
7 years ago

In 9189:

Theme Directory: Cache bump after r9188.

See #4415.

#3 follow-up: @jonoaldersonwp
7 years ago

  • Resolution fixed
  • Status closed → reopened

Can we get that to return the 404 template?

If that's a pain, could we fix/disable the JS logic which tries to set (and accidentally strips) the page title?

#4 in reply to: ↑ 3 @dd32
7 years ago

Replying to jonoaldersonwp:

Can we get that to return the 404 template?

It does, what are you seeing? (The 404 template is, and will stay, a "no themes found" page)
​https://cloudup.com/cr1o2UtW-KX

If that's a pain, could we fix/disable the JS logic which tries to set (and accidentally strips) the page title?

Uhh.. I'll see if I can get it to at least avoid clearing it.

#5 @dd32
7 years ago

In 9244:

Themes: Don't query for themes on the 404 page.

This was causing the 404 page to still query for themes and select the improper filter element.

See #4415.

#6 @dd32
7 years ago

In 9245:

Themes: Bump JS cache after r9244.

See #4415.

This ticket was mentioned in ​Slack in #meta by jonoaldersonwp. ​View the logs.
7 years ago

#8 @SergeyBiryukov
7 years ago

  • Component General → Theme Directory

​https://wordpress.org/themes/browse/non-existing-theme/ appears to return a 404 error now. What's left here?

#9 @jonoaldersonwp
7 years ago

  • Resolution → fixed
  • Status reopened → closed

Ah, let's call this done! :)

Note: See TracTickets for help on using tickets.