WordPress.org

Making WordPress.org

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#4442 closed defect (fixed)

Missing Gutenprops - WP 5.2 edition

Reported by: JeffPaul Owned by: SergeyBiryukov
Milestone: Priority: high
Component: API Keywords:
Cc:

Description

Similar to #3885, we need to capture those who received props in Gutenberg versions 4.9 to 5.4 and then ensure they're included in the 5.2 Credits API.

As @jrtashjian noted in #core Slack, the 5.2 Credits API is missing some props from the Gutenberg releases included in WP 5.2.

I've created a Google Sheet to try and help track the Gutenprops. It currently has a tab noting those who show as having commits to the Gutenberg repo on GitHub using git log (we need someone to pull the git log and attach a commits.rtf file).

Eventually, we'll need to identify the wp.org username for those GitHub names/emails/usernames and get those added as part of the 5.2 credits update.

Attachments (3)

5_4_contributors.txt (5.0 KB) - added by JeffPaul 4 months ago.
git log from @jrtashjian
4_8_contributors.txt (1.8 KB) - added by JeffPaul 4 months ago.
4.8 contributors from @jrtashjian compiled with: git shortlog -se ff0ca733a...27dca9889
5_4_missing_contributors.txt (290 bytes) - added by JeffPaul 4 months ago.
additional 5.4 credits from @jrtashjian missing from the first git log, the first command should have been this: git shortlog -se 7e72ba525...3f9b08356

Download all attachments as: .zip

Change History (14)

#1 @JeffPaul
4 months ago

Pinging @jorbin @audrasjb @coffee2code who were able to help on this last time around, in case they're able to help again.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


4 months ago

@JeffPaul
4 months ago

git log from @jrtashjian

#3 @JeffPaul
4 months ago

Note that @jrtashjian pulled that git log with

git shortlog -se c27e8eb9932b926e09dd2ff5898fcc9c8ff4e4cd...3f9b083568d7244b2d6c07d7300c188548c192b9

@JeffPaul
4 months ago

4.8 contributors from @jrtashjian compiled with: git shortlog -se ff0ca733a...27dca9889

#4 @JeffPaul
4 months ago

In chatting with @youknowriad it was determined that we need to expand to cover Gutenberg 4.8 as well, thus the additional git log file.

#5 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#6 @JeffPaul
4 months ago

@SergeyBiryukov I'll ping you once we're done pulling usernames to be credited

@JeffPaul
4 months ago

additional 5.4 credits from @jrtashjian missing from the first git log, the first command should have been this: git shortlog -se 7e72ba525...3f9b08356

#7 @JeffPaul
4 months ago

@SergeyBiryukov all good for you to go. Will need to add credits for usernames listed in Column D in the related Google Sheet.

#8 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 8736:

Credits API: Add missing credits for WordPress 5.2.

Props JeffPaul, jrtashjian, youknowriad.
Fixes #4442.

#9 @SergeyBiryukov
4 months ago

  • Component changed from General to API

#10 @SergeyBiryukov
4 months ago

In 8739:

Credits API: Add more missing credits for WordPress 5.2.

Props coffee2code.
See #4442.

#11 @SergeyBiryukov
4 months ago

In 8740:

Credits API: Update the 5.2 Noteworthy Contributors list.

See #4442.

Note: See TracTickets for help on using tickets.