Encoding issue in the Syntax Highlighter Evolved block

[truongwp]

See this page: ​https://developer.wordpress.org/themes/functionality/widgets/#registering-a-widget

Many > characters display as >.

When I view the page source, I see that the > character is encoded 2 times to >

I copied the content from the live site to my local site. This issue does not occur on my local.

I'm trying installing meta-environment to check if there is another plugin/code causes this.

[oandregal]

There is a maybe related issue in the Block Editor Handbook. See the second example at ​https://developer.wordpress.org/block-editor/tutorials/javascript/extending-the-block-editor/.

cc @coffee2code

[coffee2code]

@nosolosw: I believe the example you cited is a different Syntax Highlighter bug(?) that's causing the code block in question (the 2nd on the page) to subsume all text up to and through the next code block.

It's triggered by the fix we're doing for the double-encoded HTML entities that were appearing in code blocks. I have a fix that I'm about to land.

[coffee2code]

In 8803:

Developer: Use SyntaxHighligher-specific hook for more targeted fix for double-encoded HTML entities in code shortcodes.

Fixes a bug that cropped up using the previous approach that in specific situations somehow caused SyntaxHighlighter to have a code block subsume all text up to and through the next code block.

See #4457.

[oandregal]

@coffee2code my understanding is that rev8803 was supposed to fix the issue with the subsumed text? I still see the bug, though. I went ahead and created https://meta.trac.wordpress.org/ticket/4462 to track that separately and don't hijack this ticket.

[coffee2code]

@nosolosw: I followed up on the the ticket, but: [8803] did fix the problem, it just never got deployed to production. It has been deployed now and the issue appears resolved. Thanks for checking on it!

[truongwp]

Replying to coffee2code:

@nosolosw: I followed up on the the ticket, but: [8803] did fix the problem, it just never got deployed to production. It has been deployed now and the issue appears resolved. Thanks for checking on it!

I still see the error on the Theme Handbook page. Has it deployed on this handbook?
​https://developer.wordpress.org/themes/functionality/widgets/#registering-a-widget

[coffee2code]

@truongwp: The problem @nosolosw brought up was somewhat similar but unrelated. That has been fixed. The problem you reported isn't technically fixed yet (this ticket is still open), but I have a fix for it tested locally. I'll push the fix up shortly.

[coffee2code]

In 8843:

Developer: Fix double-encoding of > character in code shortcodes.

Props truongwp, coffee2code.
Fixes #4457.

[coffee2code]

#4420 was marked as a duplicate.

[dingo_d]

Hi @coffee2code,

There seems to be this kind of issue on this page as well: ​https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/

Example:

<?php
public function test_user_with_editor_role_can_edit_others_posts() {
$user_id = self::factory()-&gt;user-&gt;create( array(
'role' =&gt; 'editor',
) );
 
$this-&gt;assertTrue( user_can( $user_id, 'edit_others_posts' ) );
}

Maybe the fix mentioned in 6th comment could be applied to the handbook pages as well?

I'd submit a patch but I'm not 100% sure what would be a good place to put the fix to.

[coffee2code]

In 9057:

Breathe: Fix double-encoding of > character in code shortcodes.

Props dingo_d, coffee2code.
See [8843].
Fixes #4457.

[coffee2code]

In 9061:

Breathe: Expand fix for double-encoding by SyntaxHighligher to apply to & character as well.

Props garrett-eclipse, coffee2code.
See #4457.