Opened 5 years ago

Closed 4 years ago

#4471 closed enhancement (fixed)

Pipe core commits to Slack channels based on component

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: Communication (Matrix, Slack, IRC) Keywords:


Currently, in trac/config.php, commits are only piped to Slack channels based on file paths.

This works for components easily associated with particular files (Bundled Themes, Customizer, REST API), but not for components spread across multiple files (Date/Time, Privacy).

I think it would be helpful to parse the component from the beginning of the commit message, so that commits to those components could be piped to the appropriate channels as well.

Change History (5)

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.

5 years ago

#2 @tellyworth
5 years ago

  • Keywords needs-patch added

#3 @dd32
5 years ago

In 9218:

Slack: Attempt to pipe commits to channels when the commit message starts with the component.

See #4471.

#4 @dd32
5 years ago

  • Keywords needs-patch removed

[9218] should do the job here.

Unable to test, so keeping this open with the intention of checking after a few commits are made to see if it works as intended.

We'll probably need to update/add some components to the list in config.php to account for all cases.

I also note now that I forgot to update the comments in comments.php, so text and/or patches welcome to clarify it there.

#5 @dd32
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I think this is working as expected.

Feel free to re-open if it's not.

Note: See TracTickets for help on using tickets.