Changes between Initial Version and Version 1 of Ticket #4480, comment 15
- Timestamp:
- 08/25/2020 05:02:16 AM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #4480, comment 15
initial v1 1 1 Not sure about names for the new fields, if they will hold timestamps they might be better named as such? Seems confusing that `date` field is a string, but `date_utc` is a timestamp. `timestamp` and `timestamp_end` maybe? 2 2 3 `strotime()` for reversing timestamps is flawed and we are removing it in core. Is there now better time zone information than seconds offset to use? 4 5 For more robust example [https://github.com/WordPress/wordpress-develop/blob/c20372e0aa6d82fb4fdd65ed921d843b7fff6177/src/wp-includes/functions.php#L184-L191 see `date_i18n()`] (except time zone would be event, not site in this case). 3 `strotime()` for reversing timestamps is flawed. Is there now better time zone information than seconds offset to use? 6 4 7 5 Also I still would like to see API response contain event time zone somewhere, if it's now available? That's just meaningful to have, even if core won't use it right now. 6 7 Gave wrong direction conversion example, not awake yet, edited out. :)