Making WordPress.org

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#4493 closed defect (bug) (fixed)

Homepage: Height adjustment

Reported by: milana_cap's profile milana_cap Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: HelpHub (wordpress.org/documentation) Keywords: needs-patch has-screenshots
Cc:

Description (last modified by dd32)

The vertical rhythm needs to be consistent on the homepage. If the height of these two spaces could match, that would be great!

https://i0.wp.com/user-images.githubusercontent.com/617986/41545330-cd9d1cc4-72cf-11e8-8aef-150a8f7a5a12.png

Attachments (3)

WP - HH - Articles.png (340.8 KB) - added by estelaris 5 years ago.
HelpHub homepage
WP - HH - Articles v2.png (307.0 KB) - added by estelaris 5 years ago.
HelpHub Homepage without Sidebar
4493.diff (1.2 KB) - added by dufresnesteven 5 years ago.
This patch fixes padding above the section and below the support forums container.

Download all attachments as: .zip

Change History (18)

This ticket was mentioned in Slack in #docs by zzap. View the logs.


6 years ago

This ticket was mentioned in Slack in #docs by atachibana. View the logs.


6 years ago

This ticket was mentioned in Slack in #docs by zzap. View the logs.


6 years ago

#4 @estelaris
6 years ago

  • Keywords needs-design added

This ticket was mentioned in Slack in #docs by zzap. View the logs.


6 years ago

This ticket was mentioned in Slack in #docs by zzap. View the logs.


6 years ago

This ticket was mentioned in Slack in #docs by estelaris. View the logs.


5 years ago

@estelaris
5 years ago

HelpHub homepage

#8 @estelaris
5 years ago

  • Keywords needs-design removed

In order to avoid the column issue, a list-format is better to show an index of all articles in a category.
There are several advantages:

  • no issues if one description is larger than another since there will be only rows and one column
  • everything blue fonts are links, according to WP.org design, so a user can access the desired article

#9 @estelaris
5 years ago

I thought about the repetition of the sidebar and that could cause accessibility problems. I have added a new version for the homepage without the sidebar.

@estelaris
5 years ago

HelpHub Homepage without Sidebar

This ticket was mentioned in Slack in #design by estelaris. View the logs.


5 years ago

This ticket was mentioned in Slack in #docs by estelaris. View the logs.


5 years ago

@dufresnesteven
5 years ago

This patch fixes padding above the section and below the support forums container.

#12 @dufresnesteven
5 years ago

attachment:4492.diff

This takes an overwrite approach to make sure it doesn't conflict with other pages.

#13 @dd32
5 years ago

  • Description modified (diff)

#14 @coffee2code
5 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 9448:

Support theme: Adjust spacing on homepage.

Props dufresnesteven, milana_cap.
Fixes #4493.

#15 @coffee2code
5 years ago

@estelaris: I think you have some great ideas for changes to the HelpHub homepage! Since that sort of change is more substantial than simply adjusting some of the spacing, I recommend that you open a new ticket here with the proposal. That way it can be discussed in and of itself without getting lost in a ticket for something else.

Note: See TracTickets for help on using tickets.