WordPress.org

Making WordPress.org

Opened 6 months ago

Last modified 3 months ago

#4499 accepted defect

Prevent tall screenshots overflowing container

Reported by: dd32 Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Theme Directory Keywords:
Cc:

Description

Sometimes theme authors accidentally add screenshots which are too tall for the theme directory, see the below slack conversation for an example, we should limit the height of screenshots.

https://wordpress.slack.com/archives/C02RP4Y3K/p1559876587250600

Attachments (1)

themes-2-across.jpg (104.9 KB) - added by SergeyBiryukov 4 months ago.

Download all attachments as: .zip

Change History (11)

#1 @dd32
6 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 8932:

Theme Directory: Styles: Prevent tall screenshots overflowing the container.

Fixes #4499.

#2 @dd32
6 months ago

In 8933:

Theme Directory: Cache bump after r8932.

See #4499.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


4 months ago

#4 @SergeyBiryukov
4 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

As reported by @joyously, this caused issues with stretching the screenshot images on mobile views (see the screenshot above). Per Slack discussion, reopening to either revert or find a better CSS fix.

This ticket was mentioned in Slack in #themereview by dingo_d. View the logs.


3 months ago

This ticket was mentioned in Slack in #meta by joyously. View the logs.


3 months ago

#7 @SergeyBiryukov
3 months ago

  • Owner changed from dd32 to SergeyBiryukov
  • Status changed from reopened to accepted

This ticket was mentioned in Slack in #themereview by dd32. View the logs.


3 months ago

#9 @DannyCooper
3 months ago

Removing the max-height value in _main.scss:182 appears to fix this.

.theme-browser .theme .theme-screenshot img {

That may be because all the most recent screenshots use the correct dimensions though. It would need to be checked against a theme that doesn't too.

#10 @DannyCooper
3 months ago

Removing the max-height as I mentioned above could be combined with the following to enforce the correct screenshot size: https://i0.wp.com/themes.svn.wordpress.org/kvarken/3.0/screenshot.png?resize=1200,900

Note: See TracTickets for help on using tickets.