Context Navigation

← Previous Ticket
Next Ticket →

#4500 closed enhancement (fixed)

Add responsive embed support to WordCamp sites

Reported by:	melchoyce	Owned by:	iandunn
Priority:	normal	Milestone:
Component:	WordCamp Site & Plugins	Keywords:	has-patch needs-testing
Cc:

Description

The theme needs to support it: https://developer.wordpress.org/block-editor/developers/themes/theme-support/#responsive-embedded-content

Attachments (1)

4500.diff (599 bytes ) - added by ryelle 7 years ago.

Download all attachments as: .zip

Change History (8)

@ryelle
7 years ago

Attachment 4500.diff added

#1 @ryelle
7 years ago

Keywords has-patch added

4500.diff adds the theme support to CampSite, which fixes the issue we were having on WCUS with making a VideoPress embed wide-width with the "align wide" option.

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.

7 years ago

#3 @coreymckrill
7 years ago

Keywords needs-testing added
Status new → assigned
Type defect → enhancement

It seems unlikely, but we should test and make sure enabling this doesn't cause any side effects for other camps that are already using the theme and have embeds. If we can find any...

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.

7 years ago

#5 @iandunn
7 years ago

Owner set to iandunn
Resolution → fixed
Status assigned → closed

In 8984:

CampSite 2017: Add support for responsive embeds.

Props ryelle.
Fixes #4500.
See https://wordpress.slack.com/archives/C08M59V3P/p1561098727119400?thread_ts=1561093493.110200&cid=C08M59V3P.

#6 @iandunn
7 years ago

Resolution fixed
Status closed → reopened

I committed 4500.diff as last-minute support for WCEU, but meant to See #4500 rather than Fixes #4500 in the message.

The patch works fine in my very limited testing, but re-opening because we still need to consider any back-compat implications, as mentioned above.

#7 @iandunn
7 years ago

Resolution → fixed
Status reopened → closed

There haven't been any reports of back-compat issues, so this is probably fine, and new tickets can be opened if any are discovered.

Note: See TracTickets for help on using tickets.

Download in other formats:

Making WordPress.org

Context Navigation

#4500 closed enhancement (fixed)

Add responsive embed support to WordCamp sites

Description

Attachments (1)

Change History (8)

@ryelle 7 years ago

#1 @ryelle 7 years ago

This ticket was mentioned in ​Slack in #meta-wordcamp by coreymckrill. ​View the logs. 7 years ago

#3 @coreymckrill 7 years ago

This ticket was mentioned in ​Slack in #meta-wordcamp by iandunn. ​View the logs. 7 years ago

#5 @iandunn 7 years ago

#6 @iandunn 7 years ago

#7 @iandunn 7 years ago