WordPress.org

Making WordPress.org

Opened 6 months ago

Closed 4 months ago

#4500 closed enhancement (fixed)

Add responsive embed support to WordCamp sites

Reported by: melchoyce Owned by: iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: has-patch needs-testing
Cc:

Attachments (1)

4500.diff (599 bytes) - added by ryelle 6 months ago.

Download all attachments as: .zip

Change History (8)

@ryelle
6 months ago

#1 @ryelle
6 months ago

  • Keywords has-patch added

4500.diff adds the theme support to CampSite, which fixes the issue we were having on WCUS with making a VideoPress embed wide-width with the "align wide" option.

This ticket was mentioned in Slack in #meta-wordcamp by coreymckrill. View the logs.


6 months ago

#3 @coreymckrill
6 months ago

  • Keywords needs-testing added
  • Status changed from new to assigned
  • Type changed from defect to enhancement

It seems unlikely, but we should test and make sure enabling this doesn't cause any side effects for other camps that are already using the theme and have embeds. If we can find any...

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


6 months ago

#5 @iandunn
6 months ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from assigned to closed

In 8984:

CampSite 2017: Add support for responsive embeds.

Props ryelle.
Fixes #4500.
See https://wordpress.slack.com/archives/C08M59V3P/p1561098727119400?thread_ts=1561093493.110200&cid=C08M59V3P.

#6 @iandunn
6 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I committed 4500.diff as last-minute support for WCEU, but meant to See #4500 rather than Fixes #4500 in the message.

The patch works fine in my very limited testing, but re-opening because we still need to consider any back-compat implications, as mentioned above.

#7 @iandunn
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

There haven't been any reports of back-compat issues, so this is probably fine, and new tickets can be opened if any are discovered.

Note: See TracTickets for help on using tickets.