WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 15 months ago

#4524 closed task (reported-upstream)

Gitlab support for remote css

Reported by: tippl Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: needs-patch good-first-bug
Cc:

Description

Hi,
I am creating our WordCamp website for Düsseldorf/Germany right now. For this I use the remote css feature.

When I tried to add the style.css I learned that only a Github link is accepted. I would like to use Gitlab instead of Github. What is the reason for this limitation?

Best
Manja

Change History (5)

#1 @vdwijngaert
2 years ago

Hey Manja,

You are working locally, right? You can use the "wcrcss_trusted_remote_hostnames" filter to add gitlab.com to the list. This might get you started while waiting for this ticket to be resolved.

<?php
add_filter( 'wcrcss_trusted_remote_hostnames', function( $trusted_hostnames ) {
  $trusted_hostnames[] = 'gitlab.com';
  return $trusted_hostnames;
} );

Best of luck with your WordCamp!

Version 0, edited 2 years ago by vdwijngaert (next)

#2 @iandunn
2 years ago

  • Keywords good-first-bug added
  • Status changed from new to assigned

Remote CSS uses a safelist approach for security reasons, but it'd be great to add more popular platforms, and GitLab would be perfect.

The only reason we haven't already is just that there's always more work to do than people to do it, but if anyone wants to contribute a patch that'd be great. You could look at github.php as an example.

It'd be good to update the contextual help docs as well.

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


2 years ago

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.


17 months ago

#5 @dd32
15 months ago

  • Resolution set to reported-upstream
  • Status changed from assigned to closed

This ticket has been moved to GitHub https://github.com/WordPress/wordcamp.org/issues/633

Note: See TracTickets for help on using tickets.